Skip to content

tool: bump path-dep versions in lockstep in bump-version-release skill#318

Open
RealiCZ wants to merge 1 commit into
mainfrom
cz/chore/improve-bump-skill
Open

tool: bump path-dep versions in lockstep in bump-version-release skill#318
RealiCZ wants to merge 1 commit into
mainfrom
cz/chore/improve-bump-skill

Conversation

@RealiCZ

@RealiCZ RealiCZ commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix the bump-version-release skill so a version bump updates the workspace version in both required places, not just one.
  • Step 2b previously said "only change the version line — do not modify anything else", which left the internal path-dependency version requirements under [workspace.dependencies] (mega-evm, mega-state-test, mega-system-contracts) stale.
  • Because these crates are published to crates.io, Cargo resolves a path dependency by its version requirement (not the path) when publishing, so a stale requirement lets a published new-version crate resolve against an older sibling instead of the coordinated set.
  • Step 2b now requires bumping [workspace.package].version and the path-dependency requirements in lockstep, and adds a pre-commit grep -n '<old_version>' Cargo.toml check that should print nothing.

Context

  • The v1.6.1 release (chore: bump version to 1.6.1 #317) hit exactly this: only [workspace.package].version was bumped, and the Codex PR reviewer flagged the desync (P2). It was confirmed real and fixed in that PR before merge.
  • The v1.6.0 bump (be4418d) had correctly moved these same lines 1.5.1 → 1.6.0, so lockstep is the established practice.

@RealiCZ RealiCZ added spec:unchanged No change to any `mega-evm`'s behavior comp:misc Changes to the miscellaneous part of this repo api:unchanged No change to the public interface or API labels Jun 17, 2026
@claude

claude Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

LGTM.

Small, targeted fix for a real regression path. The three-crate list matches the current [workspace.dependencies] block, and the trailing grep check serves as a safety net in case new published crates are added later and the list drifts. The explanation of why version requirements matter at publish time (path is ignored, version requirement wins) is exactly the right context to give an AI agent following this skill.

@claude

claude Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Label check: The comp:misc label looks like a mismatch for this PR.

This PR only modifies .claude/skills/bump-version-release/SKILL.md, which is a markdown documentation file. The comp:doc label ("Changes in the documentation") fits better than comp:misc ("Changes to the miscellaneous part of this repo").

Suggested labels: api:unchanged, comp:doc, spec:unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api:unchanged No change to the public interface or API comp:misc Changes to the miscellaneous part of this repo spec:unchanged No change to any `mega-evm`'s behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants