fix: node draining now properly completes at stop - #194
Merged
Conversation
GaijinKa
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a unit test that occasionally fails, depending on the timing of the machine running the test. With the old implementation, any messages still in the queue or the buffer when the
updatethread exits would be dropped.In order to implement this mechanism, a couple of missing primitives were added to the transport protocol, namely,
wait()for theSignal,empty()andqsize()for theQueue. A timeout argument was also added to theputfor theQueueclass. Lastly, aJUTURNA_DRAIN_TIMEOUT` constant was introduced, to indicate how long a node should wait to drain its pending messages.PR type
Key modifications and changes
stop()mechanism, so now the node truly waits to drain all pending messagesJUTUNRA_DRAIN_TIMEOUTaddedAffected components
NodeclassQueueandSignal