Explain action theme_icons key and link beasts-32-light.png icon - #45565
Open
BaconMan1168 wants to merge 1 commit into
Open
Explain action theme_icons key and link beasts-32-light.png icon#45565BaconMan1168 wants to merge 1 commit into
BaconMan1168 wants to merge 1 commit into
Conversation
BaconMan1168
requested review from
willdurand
and removed request for
a team
September 8, 2026 10:10
github-actions
Bot
added
Content:WebExt
Contributor
|
Preview URLs (1 page) External URLs (1)URL:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explains the
theme_iconsproperty of theactionmanifest key in "Your second extension," and links thebeasts-32-light.pngicon used in the manifest.json example so readers can download it.Motivation
The manifest.json sample references
theme_iconswith abeasts-32-light.pngicon, but the article's explanation of theactionkey never mentionstheme_icons, and no download link forbeasts-32-light.pngis provided anywhere in the article. Readers following the tutorial hit a missing icon with no explanation of why it's missing or where to get it (it's optional and falls back tobeasts-32.png, but that isn't stated).Additional details
No response
Related issues and pull requests
Fixes #45524