Skip to content

Improve gradient-safe text accents - #105

Merged
mdlew merged 2 commits into
mainfrom
copilot/review-background-gradients
Oct 8, 2026
Merged

mdlew merged 2 commits into
mainfrom
copilot/review-background-gradients

Conversation

Copilot AI commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Hourly backgrounds range from dark night gradients to bright daytime palettes, so headings and links need readable accents across both. Link hover opacity also reduced contrast.

  • Accent colors: Use #080808 for daytime gradients and #fff4cc for nighttime gradients.
    accentColor = isDaytime ? "#080808" : "#fff4cc";
  • Hover contrast: Remove link opacity changes while keeping the underline hover effect.

Co-authored-by: mdlew <47911000+mdlew@users.noreply.github.com>
Copilot AI requested a review from mdlew October 8, 2026 00:18
@mdlew
mdlew marked this pull request as ready for review October 8, 2026 00:25
Copilot AI balanced review requested due to automatic review settings October 8, 2026 00:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The functional changes meet the stated accessibility goal; only minor quote-style corrections remain.

1 open finding
What changed in this PR

Improves text readability across time-based gradient backgrounds.

Changes:

  • Adds distinct daytime and nighttime accent colors.
  • Removes contrast-reducing link hover opacity.
File Description
src/​ssr.ts Updates accent colors and hover styling.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread src/ssr.ts Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@mdlew
mdlew merged commit 1f8ea00 into main Oct 8, 2026
4 checks passed
@mdlew
mdlew deleted the copilot/review-background-gradients branch October 8, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants