0.15.4 --- openkal-musl 0.20.1 beneath - #34
Merged
Merged
Conversation
The pin moves and nothing else does, for the reason this package has moved for
every release of the C library it is built above: a version written without an
operator is an exact pin in mcpp, so a consumer naming this runtime and the C
library it was built against names one musl and not two.
openkal-musl 0.20.1 carries openkal-linux 0.16.1, whose repair is where that
implementation copies the program's thread-local image. THIS PACKAGE'S OWN PROBE
IS WHAT FOUND IT: `examples/cxx` declares a `thread_local` object with a
destructor, and against 0.16.0 its guard byte --- which lives in the same image
--- read as non-zero, so the constructor never ran and the check reported
FAIL: a thread_local is constructed in a spawned thread
against the released packages. The repair is in the implementation; this release
is the pin that reaches it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin moves and nothing else does, for the reason this package has moved for every release of the C library it is built above: a version written without an operator is an exact pin in mcpp, so a consumer naming this runtime and the C library it was built against names one musl and not two.
openkal-musl0.20.1 carriesopenkal-linux0.16.1, whose repair is where that implementation copies the program's thread-local image.This package's own probe is what found the defect:
examples/cxxdeclares athread_localobject with a destructor, and against 0.16.0 its guard byte — which lives in the same image — read as non-zero, so the constructor never ran and the check reportedagainst the released packages. The repair is in the implementation; this release is the pin that reaches it.
The branch is named
openkal-0.16.1becausetools/branch-graph.shsubstitutes the C library and its backends from the branch of the same name, and the previous round's branch would have verified this against 0.20.0.