Repository navigation
Commit 963e5e1
committed
fix(eui-neo): pin the Windows API floor and name kernel32 for app-main
Auditing the one TU the `app-main` feature adds — which nothing in this index
compiled until tests/examples/eui-neo-app-main existed — turned up two
Windows-only requirements it carries:
* core/app/frame_pacing.h calls CreateWaitableTimerExW, and both mingw-w64's
winbase.h and the Windows SDK guard that declaration behind
`#if _WIN32_WINNT >= 0x0600`. The header sets no floor of its own, so it
inherits the toolchain default, and mingw-w64 has historically defaulted as
low as 0x502. Pin 0x0A00 in cflags + cxxflags rather than depend on which
default the runner's llvm ships — that is effectively what upstream builds
against via the MSVC SDK, and a command-line define is respected by
_mingw.h's `#ifndef` guard. Every other Windows API in the package is
pre-Vista, which is why this never surfaced.
* the same header reaches CreateWaitableTimerExW / SetWaitableTimer /
WaitForSingleObject / CloseHandle, so name -lkernel32. It is in every sane
default lib set, but the surrounding comment is specifically about mcpp not
inheriting CMake's CMAKE_C_STANDARD_LIBRARIES, so spelling it out is
consistent and free.
timeBeginPeriod (winmm) and MonitorFromWindow / GetMonitorInfoW /
EnumDisplaySettingsW (user32) were already covered; glfw3native.h ships in
compat.glfw's include/GLFW/.
Linux is unaffected (the flags are inside the `windows` section) and all three
eui-neo members re-verified green there.1 parent 675a544 commit 963e5e1
2 files changed
Lines changed: 46 additions & 7 deletions
Lines changed: 19 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
195 | 210 | | |
196 | 211 | | |
197 | 212 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
312 | | - | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
313 | 326 | | |
314 | 327 | | |
315 | 328 | | |
| |||
326 | 339 | | |
327 | 340 | | |
328 | 341 | | |
329 | | - | |
| 342 | + | |
| 343 | + | |
330 | 344 | | |
331 | 345 | | |
332 | 346 | | |
| |||
337 | 351 | | |
338 | 352 | | |
339 | 353 | | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
340 | 364 | | |
341 | 365 | | |
342 | 366 | | |
343 | | - | |
| 367 | + | |
344 | 368 | | |
345 | 369 | | |
346 | 370 | | |
| |||
0 commit comments