You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 675a544
Browse filesBrowse the repository at this point in the historyBrowse files
test(eui-neo): un-gate both window members to all three platforms
Both members were [target.'cfg(linux)']-gated, which made them compile to
`int main() { return 0; }` on macOS and Windows — trivially green, zero
coverage, and it left `glfw_app_main.cpp` uncompiled on every platform after
all.
imgui-window and gui-stack are linux-only because they pull the X11 packages
directly. compat.eui-neo and compat.glfw are not, and the four existing
eui-neo members already build on every runner. Audited before un-gating:
every core/ header these TUs reach (window_types, window_backend,
render_backend, primitive_geometry, render_surface, platform, input_state,
input_types, ime_bridge) is platform-clean — no windows.h, no Cocoa, no GL —
and every GLFW entry point used is portable. core::releaseInputQueue reaches
eui_ime_uninstall_message_filter, which ime_bridge.c defines on all three.
Also add GLFW_INCLUDE_NONE before <GLFW/glfw3.h>, as core/input/input_state.h
does, so GLFW does not pull a GL header of its own choosing (GL/gl.h on
Windows, the deprecated OpenGL/gl.h on macOS).
Drop the redundant `glfw = "3.4"` from both members. mcpp propagates a
transitive dependency's include_dirs and link inputs to the consumer, and
compat.eui-neo already depends on compat.glfw everywhere — verified by
removing the line and rebuilding. Matches the existing convention:
eui-neo-sdl2 includes <SDL.h>/<curl/curl.h> and eui-neo-vulkan calls
vkEnumerateInstanceVersion, neither re-declaring those packages.
macOS/Windows are CI-verified only; there is no runner for either here. The
opt-in windowed run stays linux-only (both runners are headless), same as
imgui-window.
Descriptor comment fix while re-probing the encoding: it claimed "there is no
`default-features = false` (mcpp#242)". Wrong — #242 shipped in 0.0.98. The
accurate statement is that its seedDefault gate is manifest-side and a
`default` feature declared in an xpkg DESCRIPTOR is never seeded at all, so
the consumer has nothing to switch off. Re-probed with
`default = { defines = { ... } }` and a plain consumer: macro absent on
0.0.109.
MCPP_VERSION deliberately stays at 0.0.109: #242 (0.0.98), #243 (0.0.99) and
#233/#240 (0.0.97/0.0.98) are all at or below the pin, and nothing in
2026.7.27.1 .. 2026.7.29.2 touches feature semantics, so a bump buys no
simplification here.
0 commit comments