Conversation
…DE10-Nano New kernel-module package built from ZaparooProject/Menu_MiSTer's kernel/scanout-slots/ at a master commit pin. It provides /dev/zaparoo-scanout: two exclusive write-combined 1080p framebuffer slots above the MiSTer_fb aperture. Not autoloaded. One local patch drops the module's hard-coded "6.18.38-MiSTer" release check, which made it refuse to load on any other kernel; vermagic and the remaining device-tree checks still pin it to the DE10-Nano. Enabled in the DE10-Nano defconfig only. Renovate tracks the pin monthly (driver-pin label), hash-sync refreshes the tarball hash, and ci-tests asserts the .ko.xz is in rootfs.tar. See docs/zaparoo-scanout.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Removing the upstream qualification gate allows unvalidated kernel builds to load a fixed-physical-memory module.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds the DE10-Nano-specific zaparoo_scanout kernel module package and its update/verification infrastructure.
Changes:
- Packages and enables the module with a local kernel-version patch.
- Adds Renovate hash synchronization and rootfs CI verification.
- Documents module behavior, licensing, and scope.
| File | Description |
|---|---|
Config.in |
Adds the display-driver menu. |
configs/mister_de10nano_defconfig |
Enables the package. |
package/zaparoo-scanout/Config.in |
Defines package configuration. |
package/zaparoo-scanout/zaparoo-scanout.mk |
Builds the upstream module. |
package/zaparoo-scanout/zaparoo-scanout.hash |
Pins source and license hashes. |
package/zaparoo-scanout/0001-...patch |
Removes the kernel-release guard. |
scripts/ci-tests.sh |
Verifies module installation. |
renovate.json |
Adds monthly pin updates. |
.github/workflows/renovate-hash-sync.yml |
Synchronizes archive hashes. |
docs/zaparoo-scanout.md |
Documents module operation. |
docs/renovate.md |
Adds the new commit pin. |
docs/buildroot-config.md |
Documents defconfig selection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+27
to
+29
| - if (strcmp(utsname()->release, ZAPAROO_SCANOUT_KERNEL_RELEASE) || | ||
| - !of_machine_is_compatible(ZAPAROO_SCANOUT_MACHINE)) | ||
| + if (!of_machine_is_compatible(ZAPAROO_SCANOUT_MACHINE)) |
Comment on lines
+12
to
+13
| The module declares MODULE_LICENSE("Proprietary") because its | ||
| source is GPL-3.0-or-later, so loading it taints the kernel. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package/zaparoo-scanout, built fromkernel/scanout-slots/of ZaparooProject/Menu_MiSTer at amastercommit pin. It provides/dev/zaparoo-scanout: two exclusive write-combined 1080p RGB565 framebuffer slots above theMiSTer_fbaperture. Not autoloaded."6.18.38-MiSTer"release check, which made it return-ENODEVon any other kernel. Vermagic and the remaining machine-compatible /MiSTer_fbdevice-tree checks still pin it to the DE10-Nano.configs/mister_de10nano_defconfigonly (not themister-driversprofile, since the module is Cyclone V-specific). Built for the regular kernel, notlinux-rt, like the other out-of-tree module packages.driver-pinlabel); added to both hash-sync lists;ci-tests.shassertszaparoo_scanout.ko.xzis inrootfs.tar.docs/zaparoo-scanout.md, plus §5.46 indocs/buildroot-config.md.Notes
zaparoo_scanout_uapi.h(SPDXGPL-3.0-or-later) is the licence file. Hash-sync refreshes only the tarball line, so a bump that edits that header needs its hash line updated by hand.Test plan
make zaparoo-scanoutin a fresh DE10 output: patch applies, builds against 6.18.54, installsusr/lib/modules/6.18.54/updates/zaparoo_scanout.ko.xz; vermagic6.18.54 SMP mod_unload ARMv7 p2v8make zaparoo-scanout-legal-infopasses the licence-file hashscripts/check-defconfigs.sh mister_de10nano,utils/check-package(0 warnings), shellcheck,renovate-config-validatormodprobe zaparoo_scanout,/dev/zaparoo-scanoutappears)🤖 Generated with Claude Code