linux: carry 0067 (rtw88 8821c RFE type 7) - #215
Merged
Merged
Conversation
A forum user's RTL8811CU dongle (0bda:c811) fails to probe on stock's kernel with "rfe 7 isn't supported", then "failed to setup chip efuse info" / "failed to setup chip information": its efuse reports RF front-end type 7 and rtw8821c_rfe_defs[] only has entries 0, 2, 4 and 6, so rtw_chip_board_info_setup() returns -ENODEV. Our image runs the same in-tree driver and would fail the same way. rtw88 already treats type 7 as a BTG board everywhere except that table: rtw8821c_read_efuse() sets rfe_btg for it and the coex code describes it as "2-Ant, DPDT, BTG". Realtek's vendor driver (morrownr/8821cu-20210916 @ bda65aa) confirms the grouping: phydm_init_hw_info_by_rfe_type_8821c() puts 2, 4 and 7 on SWITCH_TO_BTG, all of 0-7 load the default PHY_REG_PG/TXPWR_LMT tables (rfe_type = rfe_type_expand >> 3), BTG boards add agc_tab_diff_btg (word-for-word identical to rtw88's rtw8821c_agc_btg_type2, 780 words), and rtl8821c_set_tx_power_level() takes the 2.4 GHz power index from path B on every BTG board, commented "(RFEType == 2) || (RFEType == 4) || (RFEType == 7)". So the patch adds [7] = RTW_DEF_RFE_EXT(8821c, 0, 0, 0, 2) and extends rtw88's path-B pwr_idx_2g copy from 2/4 to 7; the table entry alone would bring the card up with the wrong 2.4 GHz TX power calibration. Type 7 is still absent from wireless, wireless-next and rtw-next (7cde94d) as of 2026-09-30. Applies at -F0 to 6.18.54 and to 7.2.8 (offset 5), so the beta series and de25nano carry it by symlink. Verified: full de10nano build (6.18.54 + RT 7.2.8) and de25nano build (7.2.8 arm64), rtw88_8821c/8821cu built for all three kernels with no warnings; ci-tests.sh 208 pass + test-initramfs.sh 8/8 and --kernel rt 3/3 (the two failures in the ci-tests run were the worktree's missing kernel tarballs, rerun with TEST_INITRAMFS_KERNEL_TARBALL); lint-kernel-patches.sh 61/61. Not yet tested on an RFE-7 dongle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The beta-series inventory counts and related documentation remain stale after adding the patch.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds RTL8821C RFE type 7 support across all kernel patch series, following Realtek’s vendor behavior.
Changes:
- Adds RFE type 7 definition and path-B 2.4 GHz power handling.
- Wires the patch into beta and DE25 series.
- Documents provenance and portability.
| File | Description |
|---|---|
docs/patch-provenance.md |
Records patch rationale and provenance. |
docs/kernel-recon/reduce.py |
Exempts the original fix from fork-origin checks. |
board/mister/de25nano/linux-patches/README.md |
Documents DE25 inclusion and updated total. |
board/mister/de10nano/linux-patches/0067-wifi-rtw88-8821c-support-rfe-type-7.patch |
Implements RFE type 7 support. |
board/mister/de10nano/linux-patches-beta/series |
Adds patch 0067 to the beta series. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The series header still said 37 of 41 shared patches, 41 entries; it is 51 of 53 shared plus the 4 beta-local, 55 entries (only 0050 and 0053 are omitted). The count drifted with the 0054-0066 dwc2 batch and 0067. docs/rt-beta-kernel.md's summary also still listed 0051 as an omission, retired 2026-09-26; its 'All series entries' row now notes the 2026-09-30 build that applied all 55 to 7.2.8 at -F0. Dated historical counts elsewhere in that doc are left as recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
0067: an RTL8811CU (0bda:c811) reporting RFE type 7 fails to probe on rtw88 ("rfe 7 isn't supported"). The patch adds the missingrtw8821c_rfe_defs[7]entry (BTG, like 2/4) and takes the 2.4 GHz power index from path B for type 7, matching Realtek's vendor driver. Still absent upstream (wireless-next, rtw-next).Carried in all three series (beta and de25nano by symlink). Builds clean on 6.18.54, RT 7.2.8 and DE25 7.2.8; ci-tests green. Not yet tested on the hardware; it'll be offered to the reporting forum user.
🤖 Generated with Claude Code