mk-release: anchor output/dist arguments to the caller's cwd - #181
Merged
Merged
Conversation
release.yml calls `scripts/mk-release.sh output dist`, so $dist was the relative string "dist". Step 4 packs the archive from inside a subshell that has cd'd to release-work/release-stage, and 7z quietly CREATES a missing output directory and exits 0 -- so the pack "succeeded" into release-work/release-stage/dist/release_20260915.7z and dist/ never got the file. The next line's `wc -c` redirection failed inside a command substitution (which set -e does not catch), so the run limped on to the round-trip step before dying with a misleading "does not exist". Absolutize both arguments before anything changes directory, and make the pack step assert its own product so a future variant of this fails at the line that caused it. Found by the v2026.09.15-beta release run (actions run 35033662179); the stock payload fetch/verify was fine, nothing upstream was yanked. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mcfbytes
added a commit
that referenced
this pull request
Sep 16, 2026
mk-release: anchor output/dist arguments to the caller's cwd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure
Run 35033662179 (
v2026.09.15-beta) died in Stage, package and verify the release assets:Nothing upstream was yanked. The stock payload fetch/verify passed clean in the same run:
Cause
release.ymlcallsscripts/mk-release.sh output dist, so$distwas the relative stringdist. Step 4 packs the archive from inside a subshell that hascd'd torelease-work/release-stage:7z creates a missing output directory and exits 0, so the pack "succeeded" — into
release-work/release-stage/dist/release_20260915.7z. Verified locally:7z a dist/x.7zfrom a directory with nodist/returns 0 and makes the directory.The next line's
wc -credirection then failed inside a command substitution, whichset -edoes not catch, so the run limped on to the round-trip step and died there with a misleading message pointing at the stock payload script.The default invocation (
out=$ROOT/output,dist=$ROOT/dist) is absolute, which is why local runs never hit this — only the CI call site passes relative paths.Fix
shellcheck -x scripts/mk-release.shis clean.To ship 20260915
This needs to be on the tagged commit, so
v2026.09.15-betahas to be re-cut after merge.🤖 Generated with Claude Code