feat(performance_manager): publish per-carriage occupancy in subway export - #801
Open
devinmatte wants to merge 2 commits into
Open
devinmatte wants to merge 2 commits into
devinmatte wants to merge 2 commits into
Conversation
Collaborator
|
Thanks @devinmatte! Actions show related unit tests are failing. Based on the logs, I'm guessing test data doesn't contain that field. Do you thin you can fix this? |
Author
|
Hi @runkelcorey looks like data from 2023 and older fails because it doesn't have any occupancy data, along with the test data needing an update. Pushed a commit to fix it. I wasn't able to run those tests locally so didn't catch it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Task: external contributor
What changes does this PR propose?
Adds per-carriage occupancy to
subway-on-time-performance-v1Sampled from the record that sets
vp_stop_timestamp, so it describes the vehicle on arrival. Includes anRPM_VERSIONbump.How were these changes validated?
Unit tests in
tests/performance_manager/test_l0_rt_vehicle_positions.py; I don't have access to anything else as an external contributor.What questions should reviewers consider?