Conversation
|
Once again, I would very much appreciate advice on the download button (where to put it, how to style it), since the current place I've put it (right next to the save/cancel buttons) is not great. Also it completely breaks when creating a new shuttle 🫠 |
jzimbel-mbta
left a comment
There was a problem hiding this comment.
Couple of comments on the controller setup, I'll take a look at the UI side as well shortly.
|
I decided to just include the download button on the index page, since you will generally need to save anyway, and saving takes you back to the index page. |
|
From checking this locally, it looks like a shuttle with no shape assigned to it (which is allowed while it's in draft state, see Probably other fields/relations that are allowed to be missing on draft shuttles would also cause the action to fail. Given that, do you think it would make sense to:
for inactive shuttles? |
|
Yeah that sounds like a good idea |
Summary of changes
Asana Ticket: 🏹 Single file describing a shuttle for use in gtfs_input
Adds a new endpoint,
/api/shuttle/:idwhich returns a JSON description of a shuttle.This endpoint only includes stop IDs, not names/locations/other info, since stops may be shared between multiple shuttle routes.
Reviewer Checklist