docs(catalog): the provenance gap is closed, so stop describing it as open - #93
Merged
Conversation
… open Phase E flagged that once the data-model §10 reconciliation landed, its module notes would be stale rather than wrong - they would describe a gap the contract had since closed. §10 merged as 86ddeb5 (#91), so they are. provenance.ts's module note now records that the gap was reported while implementing the module and that the contract has since been reconciled to match: §10 states provenance is a declaration about the source, carried onto every derived entity and vacuous for annotation-absent ones, that only the pair (ownershipState, provenance) is unambiguous, and that the declaration is required with no default. The reasoning in that note is therefore the contract's, not a local workaround - which is the part worth correcting, since a reader would otherwise think the implementation was compensating for a spec that had not caught up. Deliberately NOT touched: sc-009.test.ts. Its note is about accept-corpus materialization, which is genuinely still open, and acceptCorpusIsMaterialized is designed to fail the day someone vendors the corpus. Phase F is vendoring it now, so that test tripping is the design working rather than a defect. Docs only, no behaviour change. bun test 1721 pass / 0 fail, typecheck clean, check:freeze-hashes ok. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Comment on lines
+218
to
+219
| * This is the predicate `data-model.md` §10 names when it says only the pair is | ||
| * unambiguous, and it is exported so a check can assert on the pair rather than on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase E flagged that once the
data-model.md§10 reconciliation landed, its module notes would be stale rather than wrong — they would describe a gap the contract had since closed. §10 merged as86ddeb5(#91), so they are.provenance.ts's module note now records that the gap was reported while implementing the module and that the contract has since been reconciled to match: §10 statesprovenanceis a declaration about the source, carried onto every derived entity and vacuous forannotation-absentones, that only the pair(ownershipState, provenance)is unambiguous, and that the declaration is required with no default.That is the part worth correcting. As written, the note read as though the implementation were compensating for a spec that hadn't caught up. It isn't — the reasoning in that module is now the contract's.
Deliberately not touched
sc-009.test.ts. Its note is about accept-corpus materialization, which was genuinely still open when written, andacceptCorpusIsMaterializedis designed to fail the day someone vendors the corpus. Phase F has now vendored it — so that test tripping is the design working, not a defect to pre-empt here.Docs only, no behaviour change.
bun test1721 pass / 0 fail at the time of writing,typecheckclean,check:freeze-hashesok.