Repository navigation
Conversation
Owner
Author
|
@dbackenroth thanks for pointing out the issue -- could you please review? |
dbackenroth
approved these changes
Oct 16, 2026
dbackenroth
left a comment
dbackenroth
left a comment
Contributor
There was a problem hiding this comment.
looks great, just one minor comment on the error messages
| bad <- unique(c(bad, used[grepl(prefix_pattern, used)])) | ||
| if(length(bad) > 0){ | ||
| stop(paste0( | ||
| "The following covariate column(s) in df use reserved names that are ", |
Contributor
There was a problem hiding this comment.
this looks good, did you intend that a much longer and informative error message gets displayed when the covariate column name clashes but not when the strata column name clashes?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a reserved name check (+ test) for the TTE functions based on issue (#42) from @dbackenroth.
Also fixed a test with the
survdiffcomparison that arose and makes sure to be careful about package versions.