Fix/Make only one instance of a song have the playing icon - #2290
Open
laoluogun wants to merge 1 commit into
Open
Fix/Make only one instance of a song have the playing icon#2290laoluogun wants to merge 1 commit into
laoluogun wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, when inside the queue tab, if you have multiple of the same song queued up, each instance of the song will display as currently playing - caused by
isPlaying = track.videoId == songEntity?.videoId,Before the fix :
Multiple.Playing.Icons.Before.Fix.mp4
I fixed this by having tracking
currentSongIndexand changing isPlaying toisPlaying = index == currentSongIndex.After the fix:
Multiple.Playing.Icons.After.Fix.mp4
Note: to demonstrate the bug, the recordings were taken on a build that features a playNext duplication fix (maxrave-dev/core/pull/15) to consistently get duplicate tracks. This pull request is independent of the other, but was useful for testing.