Skip to content

Improve protocol implementation check to be based on signature compatibility - #941

Merged
mauvilsa merged 1 commit into
mainfrom
better-implements-protocol
Jul 31, 2026
Merged

Improve protocol implementation check to be based on signature compatibility#941
mauvilsa merged 1 commit into
mainfrom
better-implements-protocol

Conversation

@mauvilsa

Copy link
Copy Markdown
Owner

Before submitting

  • Did you read the contributing guideline?
  • If you used a coding agent, did you fully understand and validate all generated code and ensure it follows the contributing guidelines?
  • Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • [n/a] If this is a bug fix, did you verify that the tests fail without the code fix?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG including a pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added enhancement New feature or request refactor Improvements to the quality of the code labels Jul 31, 2026

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7a15fec) to head (6219f4e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #941   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         7885      7956   +71     
=========================================
+ Hits          7885      7956   +71     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

Copy link
Copy Markdown

Comment thread jsonargparse_tests/test_subclasses.py Dismissed
Comment thread jsonargparse_tests/test_subclasses.py Dismissed
Comment thread jsonargparse_tests/test_subclasses.py Dismissed
Comment thread jsonargparse_tests/test_subclasses.py Dismissed
Comment thread jsonargparse_tests/test_subclasses.py Dismissed
Comment thread jsonargparse_tests/test_subclasses.py Dismissed
Comment thread jsonargparse_tests/test_subclasses.py Dismissed
@mauvilsa
mauvilsa merged commit 3e986f1 into main Jul 31, 2026
32 checks passed
@mauvilsa
mauvilsa deleted the better-implements-protocol branch July 31, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor Improvements to the quality of the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants