Document tokenized From addresses for Emails#727
Conversation
Add documentation for using Contact field tokens in Email From address and name fields, including: - New section explaining tokenized From addresses in emails.rst - Sender resolution hierarchy showing priority order - Updated Email Settings in settings.rst to mention token support - Clarified Mailer is owner behavior with tokenized addresses Relates to mautic/mautic#16060
|
|
||
| It's also possible to override the 'from' field in an Email with a token from your :doc:`/contacts/custom_fields` since Mautic 5.1. | ||
|
|
||
| Check the :doc:`/configuration/variables` documentation for a list of all the available default fields. |
There was a problem hiding this comment.
Added tokenized From addresses documentation based on PR #16060 which enables Contact field tokens in FromEmailHelper.php and MailHelper.php, implementing a sender resolution hierarchy: tokenized Advanced From > owner > plain Advanced From > system default (with token support).
Source: mautic/mautic#16060
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
- Fix code block indentation (use 3 spaces per RST convention) - Add blank line after note directive - Use #. for auto-numbered lists instead of explicit numbers - Change "like" to "such as" per style guidelines - Add missing comma after "For more information"
|
Thanks for the review feedback, @adiati98! I've addressed all 5 suggestions:
The changes have been pushed to the branch. |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
Apply all 11 suggestions from reviewer @adiati98: - Add custom RST target anchors for cross-references - Fix note admonition indentation and add ref links - Add vale off/on around section heading - Bold field names consistently throughout - Improve wording for clarity
|
Thanks for the detailed review, @adiati98! I've addressed all 11 suggestions:
The changes have been pushed to the branch. Please let me know if anything else needs adjustment. |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
- Capitalize "Custom Field" per Mautic style conventions - Convert passive voice "is enabled" to active voice "you enable"
|
Thanks for the review feedback, @adiati98! I've addressed both suggestions:
The changes have been pushed to this branch. |
Address PR review feedback: - Indent note directive to be part of bullet point - Use :ref: links to existing anchors - Bold field names in the note text
|
Thanks for the review feedback, @adiati98! I've addressed the suggestion:
The changes have been pushed to this branch. |
Address review feedback from @adiati98 to combine the two cross-reference links into a single sentence for better readability.
|
Thanks for the suggestion, @adiati98! I've combined the two links into one sentence:
The change has been pushed to this branch. |
Address PR review feedback: - Use 2-space indentation for note directive (was 3 spaces) - Use 5-space indentation for note content (was 6 spaces) - Simplify :ref:`Sender resolution hierarchy<sender resolution hierarchy>` to :ref:`sender resolution hierarchy` (lowercase, no custom text)
|
Thanks for the feedback, @adiati98! I've addressed both suggestions:
The changes have been pushed to this branch. |
Addressed reviewer feedback: the note was duplicative because: - The first sentence repeated the Owner sender description - The link to sender resolution hierarchy was redundant since we're already in that section - The same note exists in configuration/settings.rst The essential information about SPF/DKIM requirements and per-Email configuration is already documented in configuration/settings.rst.
|
Thanks for the feedback! You're right — the note was redundant. I've removed it since:
The essential information about SPF/DKIM requirements remains available in the configuration documentation for users who need it. |
Open this suggestion in Promptless to view citations and reasoning process
Add documentation explaining how to use Contact field tokens in Email From address and name fields, including the sender resolution hierarchy that determines which From address Mautic uses.
Trigger Events
Tip: Use Slack message actions (⋯ menu → Update Docs) to capture doc updates without interrupting conversations 💬