Document truly transactional emails v2 feature#723
Conversation
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
|
Thanks for the review feedback, @adiati98! I've addressed all your suggestions in commit cd84557:
|
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
|
Thanks for the review feedback @adiati98! I've addressed all your suggestions:
The changes have been pushed to this PR. |
|
We'll need to rebase this to 7.2 |
|
Thanks for the feedback! I checked and the Once the |
|
I've strengthened the legal warning in the transactional emails documentation. The warning now explicitly states:
Please review the updated changes. |
escopecz
left a comment
There was a problem hiding this comment.
Looks good. Just must be merged into the 7.2 branch
|
Thank you for the approval! As noted above, the |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
|
I've addressed the PR review feedback from @adiati98: Changes made (commit
Note: The Vale vocabulary file The PR has been updated with these changes. |
|
@promptless-for-oss please rebase to 7.2 branch |
Add documentation for the new transactional email capabilities introduced in mautic/mautic#15995: - Document Send to unsubscribed contacts toggle in emails.rst - Update Send Email campaign action to describe Repeatable email toggle - Add Disable unsubscribe link in header setting to settings.rst - Document Include unsubscribed contacts permission in managing_roles.rst - Update frequency_rules.rst to explain interaction with the new toggle - Update default frequency rule description in settings.rst
Updated 'Include unsubscribed contacts' to 'Send to unsubscribed contacts' in emails.rst and managing_roles.rst to match the actual label shown in the Mautic UI.
- Fix RST indentation for warning and note admonitions (3-space indent) - Expand GDPR, CAN-SPAM, and CASL acronyms on first use - Wrap note admonition in vale off/on statements - Change passive voice to active voice in frequency rules behavior - Use dashes instead of parentheses in settings.rst - Change Gmail to GMail per style guide - Use active voice throughout
Changes per reviewer suggestions: - Change acronym format from parentheses to dashes (GDPR, CAN-SPAM Act, CASL) - Use asterisks instead of dashes for unordered list items - Replace 'functionality' with 'capability' in settings.rst - Add RFC to Vale accept.txt vocabulary
Address PR review feedback: add more prominent warning that sending marketing emails to unsubscribed contacts is illegal in many countries and can result in serious legal consequences including fines.
- Add vale off/on directives around content blocks that contain feature names and terminology that trigger Vale warnings - Add CAN, CASL, and SPAM to accept.txt vocabulary file Addresses review comments from @adiati98.
1d86379 to
8d94603
Compare
|
Done! I've rebased this PR to target the 7.2 branch as requested. The branch has been rebased and the PR base has been updated. |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
Apply all 8 reviewer suggestions from @adiati98: - Add RST target labels for cross-referencing sections - Simplify opening text and use **bold** for UI elements - Adjust permissions wording and add :ref: cross-references - Simplify frequency rules text with proper punctuation - Use active voice and restructure Campaign action table for readability
|
I've addressed all 8 suggestions from the review:
Changes have been pushed to the branch. Vale linting shows no new errors from these changes. 🤖 Generated with Promptless |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
- Remove 'CAN' and 'SPAM' from accept.txt vocabulary file
- Add vale off/on directives around regulation abbreviations (GDPR,
CAN-SPAM, CASL) in the warning block
- Rewrite frequency rules section using active voice ("When you set")
instead of passive voice ("is set")
|
I've addressed all the review feedback:
The PR is ready for re-review. |
Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
Apply PR review feedback from @adiati98: - Fix image and note indentation in settings.rst (2 to 3 spaces) - Remove unnecessary vale off/on from frequency_rules section header - Move vale off before intro paragraph, vale on after Yes case - Simplify the No case text and remove bullet formatting
|
Thanks for the review feedback @adiati98! I've applied all 5 suggestions:
The PR has been updated with these fixes. Please let me know if there's anything else that needs adjustment. |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
- settings.rst: Use specific vale rule Mautic.FeatureList = NO/YES instead of generic vale off/on for frequency rule bullet - frequency_rules.rst: Remove empty bullet point - frequency_rules.rst: Make "Send to unsubscribed contacts = No" a proper bullet and move vale on directive after it
|
Thanks @adiati98! I've applied all three suggestions:
Changes pushed to the branch. |
…irectives Replace `.. vale Mautic.FeatureList = NO/YES` with `.. vale off/on` for the frequency rule section as requested in PR review.
|
Thanks for the suggestion — I've applied it and pushed the change. Regarding why Vale keeps giving warnings despite the directives: Vale has known limitations with reStructuredText comment handling. According to Vale's GitHub issues tracker:
The original directive used rule-specific syntax ( However, Vale's RST parser has inconsistent behavior depending on the structural context (lists, titles, literal blocks). If warnings persist even with The workaround in such cases is to:
|
| * **Do Not Contact more than <number> each <period>** - This limits the number of Marketing Messages a Contact receives in a certain period of time day, week, month. Transactional messages don't count towards this limit. You can adjust this at the individual Contact level, either manually or by Preference Center setting. | ||
| .. vale off | ||
|
|
||
| * **Do Not Contact more than <number> each <period>** - This limits the number of Emails a Contact receives in a certain period of time: day, week, or month. Emails with **Send to unsubscribed contacts** enabled don't count towards this limit. You can adjust this at the individual Contact level, either manually or via the **Preference Center** setting. |
There was a problem hiding this comment.
@escopecz I have a question.
I tried this locally and I'd like to know: how to adjust Send to unsubscribed contacts at the individual level manually?
Regarding via the Preference Center setting, is it correct to set it from the "Contact Preference Center" as the screenshot below?
There was a problem hiding this comment.
I think the paragraph should be reformulated. When it states:
You can adjust this
Then the this refers to:
This limits the number of Emails a Contact receives in a certain period of time: day, week, or month.
Not to
Emails with Send to unsubscribed contacts enabled don't count towards this limit.
The Send to unsubscribed contacts is configured on each email entity. Not in the preference center. Perhaps this sentence should be added at the end of the paragraph?
Move the "Send to unsubscribed contacts" exception to the end of the paragraph so that "You can adjust this" clearly refers to the frequency limit setting, not to the transactional email behavior. Addresses review feedback from @escopecz.
|
Thanks for the feedback @escopecz! I've reordered the paragraph so "You can adjust this" now immediately follows the frequency limit sentence, with the transactional email exception moved to the end:
The change has been pushed to the branch. |
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
- Fix indentation in campaign_builder.rst (8 spaces to 6 spaces) - Add clarifying sentence about configuring Send to unsubscribed contacts on Email entities - Add vale off/on around frequency rules documentation link in note block - Add vale off/on around Unsubscribe settings section
|
Thanks for the review feedback @adiati98! I've addressed all your suggestions:
The changes have been pushed to this branch. |
| * **Do Not Contact more than <number> each <period>** - This limits the number of Marketing Messages a Contact receives in a certain period of time day, week, month. Transactional messages don't count towards this limit. You can adjust this at the individual Contact level, either manually or by Preference Center setting. | ||
| .. vale off | ||
|
|
||
| * **Do Not Contact more than <number> each <period>** - This limits the number of Emails a Contact receives in a certain period of time: day, week, or month. You can adjust this at the individual Contact level, either manually or via the **Preference Center** setting. Emails with **Send to unsubscribed contacts** enabled don't count towards this limit. You configure **Send to unsubscribed contacts** on each Email entity, not in the Preference Center. |
There was a problem hiding this comment.
@escopecz this is what Promptless came up with the update. I'm still not sure if this is correct.
There was a problem hiding this comment.
Would this capture the intention? Also, I still don't understand how to adjust the limit manually in the individual Contact level and the difference with adjust it on the Contact Preference Center.
| * **Do Not Contact more than <number> each <period>** - This limits the number of Emails a Contact receives in a certain period of time: day, week, or month. You can adjust this at the individual Contact level, either manually or via the **Preference Center** setting. Emails with **Send to unsubscribed contacts** enabled don't count towards this limit. You configure **Send to unsubscribed contacts** on each Email entity, not in the Preference Center. | |
| * * **Do Not Contact more than <number> each <period>** - This option limits the number of Emails a Contact receives in a certain period of time: day, week, or month. You can adjust this limit at the individual Contact level, either manually or via the **Contact Preference Center** setting. Emails with **Send to unsubscribed contacts** enabled in the individual Email settings don't count towards this limit. |
@promptless-for-oss don't change anything yet. Wait for reply from @escopecz.
|
Thanks for the review @adiati98! 👍 I'll hold off on making any changes until @escopecz weighs in on the frequency rules wording and the questions about:
Standing by for their input. |
Open this suggestion in Promptless to view citations and reasoning process
Add comprehensive documentation for the new transactional email capabilities: Send to unsubscribed contacts toggle, Repeatable email campaign action setting, Disable unsubscribe link header configuration, Send to unsubscribed contacts permission, and updated frequency rules behavior. Updated permission label to match the actual UI.
Trigger Events
Tip: Use Slack message actions (⋯ menu → Update Docs) to capture doc updates without interrupting conversations 💬