Skip to content

Document hour-based relative date filters for Segments#718

Merged
adiati98 merged 6 commits into
mautic:7.2from
Promptless:promptless/segment-relative-hour-filters
May 30, 2026
Merged

Document hour-based relative date filters for Segments#718
adiati98 merged 6 commits into
mautic:7.2from
Promptless:promptless/segment-relative-hour-filters

Conversation

@promptless-for-oss
Copy link
Copy Markdown

Open this suggestion in Promptless to view citations and reasoning process

Adds documentation for hour-based relative date expressions (e.g., -1 hour, +2 hours) in Segment filters, which now correctly compare the full datetime including time when used with datetime fields.

Trigger Events


Tip: Assign suggestions to team members in the Promptless dashboard to claim work 👥

@promptless-for-oss promptless-for-oss requested a review from a team as a code owner May 19, 2026 15:34
@promptless-for-oss promptless-for-oss requested review from adiati98 and favour-chibueze and removed request for a team May 19, 2026 15:34
Comment thread docs/segments/manage_segments.rst
Copy link
Copy Markdown
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@promptless-for-oss please address the suggestions

Comment thread docs/segments/manage_segments.rst Outdated
@promptless-for-oss
Copy link
Copy Markdown
Author

Thanks for the review feedback, @adiati98! I've addressed the suggestion:

✅ Changed "datetime fields" to "date and time fields" as requested

The change has been pushed to this PR.

@adiati98 adiati98 requested a review from escopecz May 21, 2026 06:06
@adiati98
Copy link
Copy Markdown
Contributor

@promptless-for-oss please rebase to 7.2 branch

promptless Bot added 2 commits May 26, 2026 11:40
Add documentation for hour-based relative date expressions (e.g., -1 hour,
+2 hours) in Segment filters. These expressions now correctly compare the
full timestamp including time, not just the date portion, when used with
datetime fields like Date last active or Date modified.
Address PR review feedback from @adiati98 to use clearer terminology
for end users.
@promptless-for-oss promptless-for-oss force-pushed the promptless/segment-relative-hour-filters branch from 6836fc5 to 7e9a363 Compare May 26, 2026 11:40
@promptless-for-oss promptless-for-oss requested review from a team and adiati98 May 26, 2026 11:40
@promptless-for-oss promptless-for-oss changed the base branch from 7.1 to 7.2 May 26, 2026 11:41
@promptless-for-oss
Copy link
Copy Markdown
Author

Done! I've rebased this PR to target the 7.2 branch as requested. The branch has been rebased and the PR base has been updated.

Comment thread docs/segments/manage_segments.rst Outdated
Change note content indentation from 2 to 3 spaces
@promptless-for-oss
Copy link
Copy Markdown
Author

Thanks @adiati98! I've fixed the RST indentation in the note (3 spaces). Ready for re-review.

@adiati98
Copy link
Copy Markdown
Contributor

@escopecz can you please review this PR? TIA! ✨

Copy link
Copy Markdown
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine 👍

@adiati98 adiati98 merged commit ea1e883 into mautic:7.2 May 30, 2026
3 checks passed
@promptless-for-oss promptless-for-oss deleted the promptless/segment-relative-hour-filters branch May 30, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants