Document LeadGetCurrentEvent for skipping last active logging#483
Document LeadGetCurrentEvent for skipping last active logging#483promptless-for-oss wants to merge 7 commits into
Conversation
Add documentation for the new skipContactLastActiveLogged() method that allows developers to prevent Contact's last active timestamp from being updated during tracking.
| } | ||
| } | ||
|
|
||
| Skipping last active logging |
There was a problem hiding this comment.
New skipContactLastActiveLogged() and isSkipContactLastActiveLogged() methods added to LeadGetCurrentEvent class in app/bundles/LeadBundle/Event/LeadGetCurrentEvent.php. The ContactTracker checks isSkipContactLastActiveLogged() and skips the last active update when true.
Source: mautic/mautic#16080
adiati98
left a comment
adiati98
left a comment
There was a problem hiding this comment.
@promptless-for-oss please address the suggestions
Address reviewer feedback by converting passive voice to active voice: - Apply suggested wording for introductory paragraph - Change 'conditions are met' to 'conditions apply' - Change 'was set by a previous listener' to 'a previous listener set' - Change 'from being updated' to 'from updating' - Change 'should be skipped' to 'to skip'
|
Thanks @adiati98 for the review feedback! I've addressed all the passive voice issues:
The changes have been pushed to this branch. |
Reworded the introduction paragraph for the 'Skipping last active logging' section to improve clarity, as suggested by @adiati98.
|
Thanks for the feedback @adiati98! I've updated the wording as suggested. The change has been pushed to this branch. |
Addresses reviewer feedback to prevent Vale from flagging correctly capitalized "HTTP" in the method descriptions.
|
Thanks for the feedback! I've wrapped the method table in Vale on/off statements to prevent the false positive on "HTTP". |
2 participants
Open this suggestion in Promptless to view citations and reasoning process
Adds documentation for the new skipContactLastActiveLogged() method in LeadGetCurrentEvent, enabling developers to prevent Contact last active timestamp updates during tracking.
Trigger Events
Tip: Enable auto-create PR in your Docs Collection to publish suggestions automatically 🤖