Update iOS and Android holder sample apps for new Holder SDK release#301
Open
avner-m wants to merge 2 commits into
Open
Update iOS and Android holder sample apps for new Holder SDK release#301avner-m wants to merge 2 commits into
avner-m wants to merge 2 commits into
Conversation
Align the iOS and Android holder tutorial sample apps with the iOS Holder SDK v6.0.0 and Android Holder SDK v7.0.0 APIs, matching the updated tutorials in MATTR Learn. iOS (v6.0.0): - Migrate ViewModel from ObservableObject/@published to @Observable/@State - Handle async initialize() via a .task modifier - Switch RetrieveCredentialResult to .success/.failure enum handling - Use OnlinePresentationSession.getMatchedCredentials() - Drop optional chaining on non-optional MobileCredential(Metadata).claims - Remove unused Combine imports Android (v7.0.0): - Bump holder SDK dependency to 7.0.0 - Handle RetrieveCredentialResult sealed interface (Success/Failure) - Rename OfferedCredential.doctype to docType - Use OnlinePresentationSession.getMatchedCredentials()
OfferedCredential.claims is now optional in iOS Holder SDK v6.0.0; guard the claim count shown for a discovered credential offer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OfferedCredential.claimsfield in the iOS holder sampleChanges
MainActivity.kt/OnlinePresentationScreen.ktfor the new releaseContentView.swift,DocumentView.swift,PresentCredentialsView.swift, andTransactionCodeInputView.swiftfor the new SDK, including safe handling of optionalOfferedCredential.claimsTest plan
🤖 Generated with Claude Code