Feat: rsvelte - #3
Draft
darbymanning wants to merge 1 commit into
Draft
Conversation
…ct updated add-ons, and replace ESLint with rsvelte tools in package.json for improved linting and formatting. Remove eslint.config.js and adjust README.md to highlight new tooling. Update vite.config.ts for compatibility with rsvelte's dynamic compile options and enhance VSCode settings for Svelte file formatting.
darbymanning
commented
Jul 28, 2026
| <div class="details" transition:slide> | ||
| We use cookies to improve your experience.<br />"Essential" cookies are needed for the site to | ||
| function. | ||
| We use cookies to improve your experience.<br />"Essential" cookies are needed for the site to function. |
Collaborator
Author
There was a problem hiding this comment.
Curious on this diff, do we need to change line width or was this previously formatted incorrectly?
darbymanning
commented
Jul 28, 2026
| export function handleError({ error }) { | ||
| import type { Handle, HandleServerError } from '@sveltejs/kit' | ||
|
|
||
| export const handleError: HandleServerError = ({ error }) => { |
Collaborator
Author
There was a problem hiding this comment.
I always dislike this added ceremony (explicitly importing types that SvelteKit has already typed through its magic 🪄)
I can either learn to embrace types everywhere even though its already typesafe, for the sake of being explicit (good argument for it) - or, can we revert this as the types are already applied?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.