Repository navigation
Don't lock the locker while it's empty - #9
Merged
Merged
Conversation
An empty locker (no documents and no folders) now opens straight away instead of showing the locked screen, on first use and after auto-lock. The catalog records a plaintext empty flag next to its ciphertext so this can be decided without the auth-bound key; nothing is decrypted on the flag's word, and catalogs from before the flag stay locked until saved. Showing the empty locker isn't an unlock: saving the first document or creating the first folder asks for fingerprint / PIN at that moment, and transfers, imports, exports and settings still ask first as before. Lock now is hidden and the auto-lock notification skipped while there's nothing to lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty locker (no documents and no folders) now opens straight away instead of showing the locked screen, both on first use and after auto-lock.
Tested on a Galaxy A17 with a fresh install: the locker opens without a prompt, saving the first document asks for a fingerprint, and the app locks normally after that.
Tests: SessionManagerTest (new cases), CatalogEmptyFlagTest.