Remember the sidebar per tab in Top Tabs, and give it a real icon - #22
Merged
Merged
Conversation
Only Threads remembered the sidebar. Leaving it collapsed the sidebar, a sidebar opened by hand on another tab stayed open until Threads, and Settings forced it open and undid that on the way out. Now every tab keeps the sidebar as the user left it there: leaving a tab records whether it was open, arriving restores it, and the user's own toggling is filed under the tab they are on. A tab never seen starts collapsed, Settings starts open for its sections, and Threads still learns its state from the first look instead of imposing one. TabsState.threadsSidebarOpen becomes `sidebar`, a map of tab to open; stored state carries the old Threads value over. sidebarStep is one rule for every tab now, with tests. The toggle observer files a change under the tab the strip last brought the sidebar in line with, not the route, because a tab click toggles the sidebar before it navigates. The Collapse the sidebar setting keeps its key and becomes "Remember the sidebar on each tab". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bb.branding.icon was "Columns", which is not one of bb's built-in icon names, so bb drew its generic fallback for the plugin. "AppWindow", a window with a band across the top, is a built-in and stands for what Top Tabs adds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Only Threads used to remember the sidebar. Leaving Threads collapsed it, a sidebar opened by hand on another tab stayed open only until you went back to Threads, and Settings forced it open and undid that on the way out.
Now every tab keeps the sidebar as you left it there:
The Collapse the sidebar on other tabs setting keeps its key and default and becomes Remember the sidebar on each tab.
Top Tabs gets a real icon.
bb.branding.iconwasColumns, which isn't one of bb's built-in icon names, so bb drew its generic fallback. It's nowAppWindow, a window with a band across the top. That's a separate commit.How
lib/tabs-model.ts:TabsState.threadsSidebarOpenbecomessidebar, a map of tab to open.parseStatecarries a stored Threads value over.sidebarStepis now one rule for every tab, plus a smallrememberSidebarhelper.components/TopTabs.tsx: the toggle observer runs on every tab, not just Threads. It records under the tab the strip last brought the sidebar in line with (previous), not the route, because a tab click toggles the sidebar before it navigates. The strip's own toggles set the state the tab already wants, so recording them changes nothing.Testing
npm test(77 pass),npm run typecheckandnpm run buildinplugins/top-tabs.🤖 Generated with Claude Code