Move ASSUME_ONLINE earlier in the script to avoid lookup of NMAP_BIN#556
Open
gcoxmoz wants to merge 1 commit intomatteocorti:masterfrom
Open
Move ASSUME_ONLINE earlier in the script to avoid lookup of NMAP_BIN#556gcoxmoz wants to merge 1 commit intomatteocorti:masterfrom
ASSUME_ONLINE earlier in the script to avoid lookup of NMAP_BIN#556gcoxmoz wants to merge 1 commit intomatteocorti:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I upgraded from a very old
check_ssl_certto recent. My security people came to me, "why are we now runningnmapon this host?" Turns out I missed--assume-online, enabled that. They come back the next day, "ok you're not runningnmapbut rather/usr/sbin/alternatives --display nmap, can you stop /that/ to remove grep noise?"Not urgent, obviously, but as I dug into it, it seems like a needless lookup / good cleanup opportunity.
The crux of the problem is,
ASSUME_ONLINEis checked later thanNMAP_BINis evaluated / auto-calculated-if-not-specified-by-options. This patch movesASSUME_ONLINEearlier, causing theNMAP_BINlookup to be skipped whennmapis not wanted, and settingDISABLE_NMAPso you don't haveDISABLE_NMAPandASSUME_ONLINEthat mostly mean the same thing later.Thanks for looking.