[codex] Add Catalyst archive options to xc-ci#10
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d421f22f44
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ensure_profiles_for_archive "$CATALYST_ARCHIVE"; then | ||
| generate_export_plist "$CATALYST_EXPORT_PLIST" "$CATALYST_ARCHIVE" |
There was a problem hiding this comment.
Include Mac provisioning profiles for Catalyst export
When --catalyst uploads are enabled, this new path calls ensure_profiles_for_archive, but that helper only scans ~/Library/MobileDevice/Provisioning Profiles for *.mobileprovision. Apple’s provisioning docs distinguish Mac App Store Connect profiles for “macOS apps including those configured with Mac Catalyst,” and the download docs say profiles may have a .mobileprovision or .provisionprofile extension, so a correctly installed Mac Catalyst distribution profile can be ignored here and the script exits before export/upload with “Missing installed App Store provisioning profile.”
Useful? React with 👍 / 👎.
Summary
Adds Mac Catalyst archiving support to
xc-civia--catalystand--catalyst-only.Adds
--no-uploadso local archive runs can skip App Store Connect authentication, build-number lookup, export, and upload steps.Rebases the local change onto the updated
mainflow that exports manually signed artifacts and uploads withasc builds upload.Validation
bash -n xcode-agent-tools/xc-cigit diff --check