Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MO Q1 native preparation read past its SQL root names because Decimal256's private four-limb STRUCT carrier was counted as nested SQL fields. Mark canonical exact-decimal carriers opaque through the query-scoped importer policy, so each remains one result column and following aliases keep their positions.
Pins merged importer #5, revision
99c7ca3b6f8f3159239e119ed2982d42f98c4690. The callback validates the full canonical carrier through the existing descriptor decoder. The regression binds Decimal64/128/256 at precision 15 followed by an independent BIGINT result, asserting both headings and the exact physical descriptor; ordinary STRUCTs remain outside this policy. Numeric arithmetic, GPU kernels, C ABI layouts and capability mask 31 are unchanged.Validated at head
433cadd43a10442b0825a23234fb6d859207e9d5, frozen Piximo:source_dirty=false); all 73 artifact fingerprints, ABI/header and canonical literal schema match.upstream-dev-merge; zero commits behind; self-review found no in-scope blocker.The merged importer tree matches the tested fix. Its canonical importer regressions previously passed 157 / 3, and joint development binding coverage passed 1,009 / 84. Importer distribution CI's seven failures were classified against its exact clean base, including a prior STRUCT field-selection failure/crash and five independently reproduced later failures; no assertion was weakened or skipped. This does not claim full distribution or compiler CI is green; current-head CI is tracked separately.
MO C is saved locally and will pin this PR only after it merges, then rerun all-22 native preparation and full public numeric validation. The parity campaign D follows merged, validated C. Refs matrixorigin/matrixone#28968 and matrixorigin/matrixone#28966.