Repository navigation
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Reject different result-set column counts before indexing column arrays. Previously, a larger expected shape threw ArrayIndexOutOfBoundsException, while a smaller expected shape could silently accept extra actual columns. Existing same-shape label/full-metadata policies are unchanged.
Five focused tests cover both mismatch directions, empty/nonempty shapes, equal-shape controls and existing metadata-policy behavior. Only the comparator and its unit test are changed; no product BVT expected result, connection config, log or artifact is committed.
Direct validation (local, not inferred from CI)
mvn -o -DskipTests -Dassembly.skipAssembly=true package, after the separate full test pass. The default assembly plugin version rejected the old singular descriptor configuration despite assembly.xml existing; distribution assembly was skipped, not fixed in this PR.e5dd4724f782067e1c76c38c9d2f55cebceda4a9, runtimegit_version()=e5dd4724f7.Evidence excerpts:
Raw logs, exact sources and hashes are retained in the originating task's outputs/attempt-14 (not uploaded by this PR). Found while executing Feature #23371's AINC-060; this tester fix does not claim the feature caused the pre-existing comparator defect or baseline differences.