Skip to content

docs(skills): validate GitHub templates before delivery - #30159

Merged
XuPeng-SH merged 3 commits into
mainfrom
codex/skill-github-delivery
Oct 14, 2026
Merged

XuPeng-SH merged 3 commits into
mainfrom
codex/skill-github-delivery

Conversation

@XuPeng-SH

@XuPeng-SH XuPeng-SH commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

Related to #25267.

What this PR does / why we need it:

PR and issue bodies submitted through CLI/API can miss repository template fields or use headings and line endings incompatible with description consumers. Add a shared GitHub delivery reference to mo-dev and mo-self-review that checks current templates and body encoding before publication, then verifies the stored body afterward.

The guidance requires a real, relevant issue reference, preserves author content and intentional code escapes, covers required issue-form fields, and distinguishes a rendering failure from an unverified CRLF hypothesis. Both skills link to the same contract and keep publication checks in the appropriate phase.

Validation:

  • Both skills pass skill-creator validation; shared-reference links resolve.
  • Executed the documented normalization example against BOM/mixed line endings, Unicode, literal code escapes, LF idempotence, empty input, and invalid UTF-8.
  • Complete diff review and git diff --check pass.

This is agent guidance; the CRLF root-cause hypothesis for #30091 remains unverified.

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@mergify mergify Bot added the kind/documentation Improvements or additions to documentation label Oct 14, 2026
@XuPeng-SH

XuPeng-SH commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

mo-bot work · mo-bot-local · superseded

Commit: aaf143df78fa0382df5e0faac69ae35c488c6a75

PR input head changed

@matrix-meow matrix-meow added the size/XS Denotes a PR that changes [1, 9] lines label Oct 14, 2026
@XuPeng-SH

XuPeng-SH commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

mo-bot review · mo-bot-local · done

Commit: 217fd97e9c5e57df967a048d89929fa39b97bec8

Review completed. Read the assessment.

@XuPeng-SH XuPeng-SH left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mo-bot review · mo-bot-local · review

Commit: 217fd97e9c5e57df967a048d89929fa39b97bec8

Assessment: approve

Reviewed the complete three-file documentation change. Both skills reuse one coherent delivery contract with appropriate authorization boundaries and correctly separated publication checks. No actionable defects found; production behavior and SQL performance are unchanged.

Model: gpt-6-astra / xhigh

Session: 01a12d8f-7dea-77c2-a565-38d45b5564e4 · slot 0 · generation 0

Validation:

  • Both skills passed validation; shared-reference links resolve. Frozen PR headings match the repository template and Mergify configuration.

  • Executed the documented normalization example against BOM, mixed line endings, Unicode, literal escapes, empty input, idempotence and invalid UTF-8. All checks passed.

  • Verified clean source, diff whitespace and the successful check receipt against the frozen head. Logs and evidence: /home/xupeng/.local/state/mo-bot/jobs/413cedafbbbd4fec937cbb37/attempt-1/review-evidence.json.

Limitations:

  • No live publication or Mergify parser execution was performed. The guidance correctly leaves the original CRLF root-cause hypothesis unverified.

  • Some CodeQL checks remained pending in the supplied snapshot and were not counted as passes. Product tests are not applicable to this documentation-only delta.

@XuPeng-SH
XuPeng-SH merged commit 5a0570e into main Oct 14, 2026
15 of 16 checks passed
@XuPeng-SH
XuPeng-SH deleted the codex/skill-github-delivery branch October 14, 2026 08:09

This branch was successfully deployed

1 active deployment
ci — 21c48075 Deployed Oct 14, 2026 by XuPeng-SH via Matrixone Utils CI / pr-size-label #58445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation Improvements or additions to documentation size/XS Denotes a PR that changes [1, 9] lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants