Move job summary opt-out check to plugin service classes#29
Merged
Conversation
davidbuzinski
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MW_GENERATE_JOB_SUMMARYenvironment variable name toMW_GENERATE_SUMMARYMW_GENERATE_SUMMARYenvironment variable check from the plugin implementations to their respective service classes. When job summary is disabled, plugins are no longer instantiated rather than being instantiated and doing nothingChanges
TestResultsSummaryPluginService.m— guard plugin creation withMW_GENERATE_SUMMARYcheckgetDefaultPlugins.m— only add build summary plugin whenMW_GENERATE_SUMMARYis"true"TestResultsSummaryPlugin.m— removed env var check (plugin always generates artifacts when instantiated)BuildSummaryPlugin.m— removed env var checkParallelizableBuildSummaryPlugin.m— removed env var checktestResultsSummary.unit.test.ts— updated test to expectnullon invalid JSON