Skip to content

Move job summary opt-out check to plugin service classes#29

Merged
mw-kapilg merged 3 commits into
mainfrom
kapilg/update-plugins
May 14, 2026
Merged

Move job summary opt-out check to plugin service classes#29
mw-kapilg merged 3 commits into
mainfrom
kapilg/update-plugins

Conversation

@mw-kapilg
Copy link
Copy Markdown
Contributor

@mw-kapilg mw-kapilg commented May 14, 2026

Summary

  • Update MW_GENERATE_JOB_SUMMARY environment variable name to MW_GENERATE_SUMMARY
  • Move the MW_GENERATE_SUMMARY environment variable check from the plugin implementations to their respective service classes. When job summary is disabled, plugins are no longer instantiated rather than being instantiated and doing nothing

Changes

  • TestResultsSummaryPluginService.m — guard plugin creation with MW_GENERATE_SUMMARY check
  • getDefaultPlugins.m — only add build summary plugin when MW_GENERATE_SUMMARY is "true"
  • TestResultsSummaryPlugin.m — removed env var check (plugin always generates artifacts when instantiated)
  • BuildSummaryPlugin.m — removed env var check
  • ParallelizableBuildSummaryPlugin.m — removed env var check
  • testResultsSummary.unit.test.ts — updated test to expect null on invalid JSON

@mw-kapilg mw-kapilg requested a review from davidbuzinski May 14, 2026 14:36
@mw-kapilg mw-kapilg merged commit 8938b50 into main May 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants