Repository navigation
Keep the Property Inspector read-only for MAT-files, as for dictionaries and models - #92
Merged
Merged
Conversation
…tionaries and models The inspector took edits for a MAT-file's variables, and for nothing else. What a file type can edit is core's to decide and say; how the extension presents it is the extension's, and one panel should behave the same for every file. Until every property setter the panel would reach is qualified, the panel is read-only for all of them. So the MAT-file editor gives the inspector no edit channel any more. piBuilder marks every row read-only again, whatever core's property sheet allows, and no row carries an edit key; the webview sends no edit and shows no refusal line; PropertiesViewProvider routes no edit; the editor has no inspector-edit gesture. Their tests go with them, and the change log no longer says MAT-file object properties can be edited in the Properties panel. The table is unchanged: its cells still take every edit they took, and the Add gallery, Bus element rows, struct field renames and the reasons core gives for a refused Add are as they were. A new test holds every row of every class the MAT-file gallery creates, a Bus's element included, read-only in the panel, while core itself offers edits of many of them.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Property Inspector took edits for a MAT-file's variables, and for nothing else. What a file type can edit is core's decision; how the extension presents it is the extension's, and the panel should behave the same for every file. Until every property setter the panel would reach is qualified, the panel stays read-only everywhere.
Tests