feat: adds metrics interface - #123
Open
S T (staheri14) wants to merge 4 commits into
Open
Conversation
S T (staheri14)
force-pushed
the
sanaz/obs-metrics-interface
branch
from
August 7, 2026 17:58
3a1ec14 to
0f73d6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #109: the trait interface the node code will record metrics against. Interface only; no backend yet.
Included in the PR
observabilitymodule: the recording traits (SearchMetrics,LookupTableMetrics,NetworkMetrics) and theirNodeMetricscomposite, the label enums they use, and a unimock double per trait.Directionpromoted topub(now used in a public trait signature; this is whycore/is touched).Follow-ups
Closes #109.