Repository navigation
Show a drop target while a file is dragged over the chat - #633
Merged
Merged
Conversation
Closes #632 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While a file is dragged over the page, a full-page drop target shows. A dashed accent border and "Drop to attach" say the drop will be accepted. A red border and a reason say it will be ignored, either "Wait for the reply to finish" or "Attaching files is off here". The target never takes the pointer. It hides on drop, on leave, on window blur and on the next pointer move.
Closes #632
Type of change
How it was tested
pnpm checkpasses (lint, typecheck, 4171 tests, build).Composer.test.tsxcover the accepted and refused states, nested enter and leave events, a render in the middle of a drag, and the reset on blur.ChatService.skillReview.test.tsfailed twice in full runs of the suite and passes alone and on rerun. It is unrelated to this change.Checklist
pnpm checkpassesdocs/, orCHANGELOG.mdfor user-facing changes)