fix(radio): dispatch input event on keyboard navigation#5949
Open
akinshaywai wants to merge 1 commit intomaterial-components:mainfrom
Open
fix(radio): dispatch input event on keyboard navigation#5949akinshaywai wants to merge 1 commit intomaterial-components:mainfrom
akinshaywai wants to merge 1 commit intomaterial-components:mainfrom
Conversation
Native <input type="radio"> fires both 'input' and 'change' events
when a radio is selected via arrow key navigation. md-radio was only
dispatching 'change', causing frameworks and listeners that rely on
the 'input' event (e.g. React's onChange which maps to the DOM input
event) to miss keyboard-driven selections.
Fire an InputEvent('input', {bubbles: true, composed: true}) before
the existing 'change' dispatch in SingleSelectionController to match
native behavior. Also adds a test asserting the input event fires on
arrow key navigation.
Fixes material-components#5447
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #5447
Native
<input type="radio">fires bothinputandchangeevents when a radio button is selected via arrow key navigation.<md-radio>only dispatcheschange, which means:onChangemaps to the DOMinputevent, notchangeinputevents is silently skipped on keyboard navigationFix
In
SingleSelectionController.handleKeyDown, fire anInputEvent('input', { bubbles: true, composed: true })before the existingchangeevent, matching native<input type="radio">order and behavior:composed: trueso the event crosses shadow DOM boundaries (same as native)inputfires beforechange(same order as native)A new test
dispatches an input event on user navigationis added alongside the existingdispatched a change event on user navigationtest.Testing