Skip to content

Solution - #2075

Open
webdevnikfull wants to merge 1 commit into
mate-academy:masterfrom
webdevnikfull:develop
Open

Solution#2075
webdevnikfull wants to merge 1 commit into
mate-academy:masterfrom
webdevnikfull:develop

Conversation

@webdevnikfull

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution. You correctly implemented parseSalary, sortList, and getEmployees with the required names, sorted the list by salary in descending order, appended the sorted items back to the list, and produced the employee array with the expected schema { name, position, salary, age }. The functions are invoked appropriately and the core behavior aligns with the task requirements.

Minor suggestions (non-blocking):

  • Consider parsing name from a specific element or dataset to avoid including other text if dataset.name is missing.
  • Avoid parseInt(...) || null so that an age of 0 isn’t converted to null; check explicitly for NaN instead.
  • If multiple lists exist, a more specific selector than document.querySelector('ul') could prevent targeting the wrong list.

Overall, nice job structuring the code and meeting the requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants