*

[ZloyHoma]

- [DEMO LINK](https://ZloyHoma.github.io/js_task_parse_list_DOM/)

[mateacademy-ai-mentor]

Review Summary

I am requesting changes because a couple of critical requirements aren’t fully met and may cause tests to fail. While sorting works correctly, the getEmployees function returns salary and age as strings instead of numbers, which violates the required schema and likely breaks consumers expecting numeric types. Please update the mapping so salary uses your transformSalary(li.dataset.salary) and age is converted with Number(li.dataset.age).

Additionally, your query selection grabs all li elements globally, which can pick up unrelated items if multiple lists exist. Scope the selection to the specific list container (e.g., select the target ul first and then its children) to ensure correct behavior. Finally, ensure the demo link uses your actual GitHub username and points to a deployed page as required. Once these are addressed, the solution should meet all requirements—nice work on the sorting logic and salary parsing helper so far!

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

Review Summary

I am approving this submission. The solution correctly converts salary and age to numbers, implements a clear transformSalary helper, and sorts the list in descending order by salary. Both getEmployees and sortList are implemented and invoked, and the employee objects include the required fields using data attributes. One improvement to consider next time: scope DOM queries to the specific list container (e.g., select the target ul first and query its li items) to avoid accidentally including unrelated lists. Also, consider explicitly constructing the returned employee objects to avoid leaking unexpected dataset keys. Overall, solid work—clean, functional, and meeting the task requirements.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Footnotes

1. Rate AI review example ↩