add task solution - #2058
add task solution#2058Jonoreh wants to merge 2 commits into
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation of both sortList and getEmployees functions is correct and meets the functional requirements. However, the returned array from getEmployees(employeesArray) is not being captured. If your tests verify the return value, you need to store it (e.g., const result = getEmployees(employeesArray);) or log it to make it accessible. This is a critical issue because tests checking the return value will fail without it being captured or output.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| sortList(employeesArray).forEach((employee) => { | ||
| employee.parentNode.appendChild(employee); | ||
| }); | ||
|
|
||
| getEmployees(employeesArray); |
There was a problem hiding this comment.
The returned array from getEmployees is not captured. If tests verify this return value, you need to store it (e.g., const result = getEmployees(employeesArray);) or log it to make it accessible.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. All task requirements are met - the employeesData variable at line 42 now correctly captures the return value from getEmployees(), and both sortList and getEmployees functions are properly implemented with correct parameter handling, salary conversion, and sorting logic. The previous issue has been successfully resolved.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK