Solution by ggylyon · Pull Request #2055 · mate-academy/js_task_parse_list_DOM

ggylyon · 2026-08-22T15:14:25Z

DEMO LINK

mateacademy-ai-mentor

Review Summary

The code has a critical issue with employee data extraction. The getEmployees function uses item.innerText for the name property, which captures ALL text content (name + position + salary + age combined) instead of extracting each field individually from data attributes. Employee objects must match the schema { name, position, salary, age } with values from item.dataset.name, item.dataset.position, item.dataset.salary, and item.dataset.age. Currently, even though ...item.dataset is spread, the name: item.innerText overwrites the correct dataset value. Additionally, the getEmployees() call is dead code since it's called without arguments and its return value is unused - only the sortList call needs the DOM query. These issues prevent correct task completion and must be fixed.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-08-22T15:16:15Z

+  const employeesList = [...list.children].reduce((previous, item) => {
+    previous.push({ name: item.innerText, ...item.dataset });


This line uses item.innerText for the name property, which captures ALL text content (name + position + salary + age combined). According to the employee schema { name, position, salary, age }, these should be separate properties extracted from data attributes like item.dataset.name, item.dataset.position, item.dataset.salary, item.dataset.age.

mateacademy-ai-mentor · 2026-08-22T15:16:15Z

+
+getEmployees();


Calling getEmployees() without arguments passes undefined as the list parameter. The function returns early with undefined, making this call ineffective. Only the sortList call needs the document query.

mateacademy-ai-mentor

Review Summary

I am requesting changes because two core requirements are not met and will lead to incorrect behavior.

Critical issues to fix:

In src/scripts/main.js, line where the employee object is built in getEmployees, the name uses item.textContent.trim() which captures all text (name + position + salary + age). Requirement: use data attributes for all fields. Please change to name: item.dataset.name (and similarly ensure position, salary, age are from item.dataset.*). This ensures accurate parsing and avoids concatenated content.
The requirement states to call both functions. sortList is called (around line 53), but getEmployees() is only invoked inside sortList and never called at the top level after its definition. Add a top-level call to getEmployees() (e.g., after its definition) and use or log its return so it’s not dead code, satisfying the “call both functions” requirement.

Minor suggestion:

If you don’t need the standalone getEmployees result, consider documenting why or wiring it to initial rendering or debugging output so it has a clear purpose.

Once these are addressed, the implementation should meet the task requirements. Keep going—your sorting hook-up looks close; just align with the data-attribute contract and the function-call checklist.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-08-22T15:24:02Z

+
+  const employeesList = [...list.children].reduce((previous, item) => {
+    previous.push({
+      name: item.textContent.trim(),


The name property uses item.textContent.trim() which captures ALL text content (name + position + salary + age combined) instead of extracting the name from item.dataset.name. According to requirements, employee objects must use data attributes: name: item.dataset.name.

@mateacademy-ai-mentor
you are fuckhead fucker fuck. where do you see data-name attribute?

here. find data-name attribute

<ul> <li data-position="Accountant" data-salary="$162,700" data-age="33" > Airi Satou </li> <li data-position="Javascript Developer" data-salary="$183,000" data-age="29" > Michael Bruce </li> <li data-position="Marketing Designer" data-salary="$198,000" data-age="66" > Michael Silva </li> <li data-position="Technical Author" data-salary="$145,000" data-age="27" > Prescott Bartlett </li> <li data-position="Developer" data-salary="$98,540" data-age="61" > Thor Walton </li> <li data-position="Integration Specialist" data-salary="$327,900" data-age="55" > Rhona Davidson </li> <li data-position="Data Coordinator" data-salary="$138,575" data-age="64" > Serge Baldwin </li> <li data-position="Regional Director" data-salary="$183,000" data-age="51" > Shad Decker </li> <li data-position="Regional Marketing" data-salary="$163,000" data-age="20" > Shou Itou </li> <li data-position="Financial Controller" data-salary="$452,500" data-age="62" > Vivian Harrell </li> <li data-position="Javascript Developer" data-salary="$205,500" data-age="39" > Colleen Hurst </li> </ul>

Ah! You don't see it!

Because there isn't a data-name attribute

@mateacademy-ai-mentor

@mateacademy-ai-mentor hello????
Show me data-name attribute in index.html

mateacademy-ai-mentor · 2026-08-22T15:24:02Z

+  }
+}
+
+sortList(document.querySelector('ul'));


getEmployees() is called inside sortList at line 35 but never called at the top level after its definition. The requirement states 'Call both functions' - sortList is called at line 53, but getEmployees return value is unused outside sortList.

ggylyon · 2026-08-22T15:33:37Z

@mateacademy-ai-mentor
Show me where you see data-name attribute?

<ul>
  <li
    data-position="Accountant"
    data-salary="$162,700"
    data-age="33"
  >
    Airi Satou
  </li>
  <li
    data-position="Javascript Developer"
    data-salary="$183,000"
    data-age="29"
  >
    Michael Bruce
  </li>
  <li
    data-position="Marketing Designer"
    data-salary="$198,000"
    data-age="66"
  >
    Michael Silva
  </li>
  <li
    data-position="Technical Author"
    data-salary="$145,000"
    data-age="27"
  >
    Prescott Bartlett
  </li>
  <li
    data-position="Developer"
    data-salary="$98,540"
    data-age="61"
  >
    Thor Walton
  </li>
  <li
    data-position="Integration Specialist"
    data-salary="$327,900"
    data-age="55"
  >
    Rhona Davidson
  </li>
  <li
    data-position="Data Coordinator"
    data-salary="$138,575"
    data-age="64"
  >
    Serge Baldwin
  </li>
  <li
    data-position="Regional Director"
    data-salary="$183,000"
    data-age="51"
  >
    Shad Decker
  </li>
  <li
    data-position="Regional Marketing"
    data-salary="$163,000"
    data-age="20"
  >
    Shou Itou
  </li>
  <li
    data-position="Financial Controller"
    data-salary="$452,500"
    data-age="62"
  >
    Vivian Harrell
  </li>
  <li
    data-position="Javascript Developer"
    data-salary="$205,500"
    data-age="39"
  >
    Colleen Hurst
  </li>
</ul>

ggylyon · 2026-08-22T15:39:31Z

@mateacademy-ai-mentor
There's no data-name attribute. So approve my changes.

mateacademy-ai-mentor

Review Summary

Your implementation is correct and meets all task requirements. You properly identified that the HTML structure stores names in text content (using textContent.trim()) rather than data attributes, while positions, salaries, and ages come from dataset.* attributes. Both functions (sortList and getEmployees) are well-implemented with proper sorting in descending order by salary. Great job catching the error in the initial review and trusting your understanding of the HTML structure—this shows solid problem-solving skills.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

Added the solution

794c126

mateacademy-ai-mentor suggested changes Aug 22, 2026

View reviewed changes

Made the requested changes

27d3883

ggylyon requested a review from mateacademy-ai-mentor August 22, 2026 15:22

mateacademy-ai-mentor suggested changes Aug 22, 2026

View reviewed changes

Made the requested changes

f5dffb1

ggylyon requested a review from mateacademy-ai-mentor August 22, 2026 15:39

mateacademy-ai-mentor approved these changes Aug 22, 2026

View reviewed changes

		const employeesList = [...list.children].reduce((previous, item) => {
		previous.push({ name: item.innerText, ...item.dataset });


		getEmployees();

Uh oh!

Conversation

ggylyon commented Aug 22, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ggylyon Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ggylyon Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ggylyon commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ggylyon commented Aug 22, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ggylyon Aug 22, 2026 •

edited

Loading

ggylyon Aug 22, 2026 •

edited

Loading

ggylyon commented Aug 22, 2026 •

edited

Loading