Skip to content

my solution - #1892

Open
yevhen-dts wants to merge 1 commit into
mate-academy:masterfrom
yevhen-dts:develop
Open

yevhen-dts wants to merge 1 commit into
mate-academy:masterfrom
yevhen-dts:develop

Conversation

@yevhen-dts

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation successfully meets all task requirements. The code correctly iterates through the people array, creates table rows with all six required cells (name, gender, born, died, age, century), calculates age as died - born and century using Math.ceil(died / 100), finds the dashboard table, and appends the rows. The gender field properly converts 'm'/'f' to 'Male'/'Female'. The SCSS file remains unchanged as required. Minor code quality suggestions like more descriptive variable names or explicit tbody elements are noted but not blocking issues—your solution works correctly and fulfills all core requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants