Skip to content

solution - #1890

Open
AlucardYagamiGame wants to merge 2 commits into
mate-academy:masterfrom
AlucardYagamiGame:develop
Open

AlucardYagamiGame wants to merge 2 commits into
mate-academy:masterfrom
AlucardYagamiGame:develop

Conversation

@AlucardYagamiGame

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution. The table is correctly populated with six cells per person (name, gender mapped to Male/Female, born, died, age as died - born, and century via Math.ceil(died / 100)), and rows are appended to the .dashboard table as required. Functionality appears complete and coherent, and you did not alter styles or HTML.

As a minor improvement, consider guarding the table selection (e.g., check const table = document.querySelector('.dashboard') is not null) to avoid runtime errors if the element is missing. Also, ensure the demo link in your PR uses your actual GitHub username per the checklist. Nice work—clean and effective implementation!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants