final result - #1884
final result#1884kosigorek wants to merge 2 commits into
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The Cypress end-to-end test is failing because 'Male' is not appearing in the generated table. The test expects the gender column to display 'Male' or 'Female' values, but the table generation code appears to be accessing the wrong property. While the code review mentions person.sex is being used, the test failure indicates either a mismatch between the property name in the data (likely 'gender') and what the code accesses ('sex'), or the values being stored are not 'Male'/'Female'. You need to verify that your code accesses the correct property name in people.json that contains 'Male'/'Female' values, and that this value is properly appended as a table cell in the correct position.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution correctly implements all task requirements. The getGender() function on lines 360-362 properly converts 'm'/'f' values to 'Male'/'Female' strings, which resolves the previous issue. All 6 table cells are created in the correct order (name, gender, born, died, age, century), with accurate age calculation (person.died - person.born) and century calculation (Math.ceil(person.died / 100)). Rows are properly appended to the .dashboard table. Your implementation should pass the Cypress end-to-end test.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.