SOF-8032: new ide - #165
Open
k0stik wants to merge 8 commits into
Open
Conversation
…mpute workarounds [release] @mat3ra/ide's ComputedEntityMixin is now generic over the compute payload (wip-a02d972 - see that commit for the full design/rationale, including the ComputeField<C> conditional-optionality fix this depends on). Point wode at it and clean up both interface merges that were working around the old `readonly compute: unknown`: - Workflow.ts: ComputedEntityMixin<WorkflowSchema["compute"]>, dropping the own `compute: WorkflowSchema["compute"]` member and its `// TODO: fix ComputedEntityMixin and remove this`. - Subworkflow.ts: ComputedEntityMixin<SubworkflowSchemaMixin["compute"]>, dropping the unexplained `Omit<ComputedEntityMixin, "compute">`. Verified both Gate A (unchanged Workflow.ts/Subworkflow.ts against the new ide types - 0 errors, confirming the generic's default type param is backward compatible) and Gate B (the cleanup above) via `tsc --noEmit`; `npm test` 48/48 passing; `npm run lint` clean on both changed files (wode, unlike jode/ide, already has a working @typescript-eslint setup). package-lock.json regenerated with a plain `npm install`/`npm ci` (no --legacy-peer-deps) so CI's `npm ci` in release-wip stays in sync.
…ndler cleanup, no behavior change) [release]
…n now extends InMemoryEntity)
…ge no longer reads owner)
…n split into computedEntityMixin + infrastructureMixin, no source changes needed here)
…l dropped from infrastructureMixin)
…ueue optionality now tied to compute's own)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.