Release 0.3.1#18
Conversation
Pasting an Obsidian table followed by a paragraph threw "TypeError: Cannot read properties of null" from ProseMirror's slice fitter. Foundry treats any table with a <thead> (every GFM table from marked) as an isolating "complex" table; fitting an open slice of [isolating table, paragraph] past the isolating boundary dereferences null. insertHtml now tries the open-slice replaceSelection first (preserving inline-merge behavior) and, only on a fitter crash, falls back to parsing a full document and inserting fully-closed content via replaceWith. Building the transform does not mutate state, so the try/catch is safe. Adds tests/insert.test.js (first unit test for insert.js) with a happy-path and an issue #16 regression test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
GFM and marked absorb a pipe-less line directly after table rows as a trailing single-cell row, so a note like "*Digested from ...*" placed right under a table became a stray table cell. Obsidian and Typora end the table at that line instead. Add isolateTables() to the Obsidian layer: when a table's last row is immediately followed by a non-blank, pipe-less line, insert a blank line so it parses as its own block. Wired into convert() after stripWikiLinks (so wikilink pipes are already gone) and gated by the existing obsidian option. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fix: Obsidian table paste crash and glued-prose stray row (#16)
|
Warning Review limit reached
More reviews will be available in 55 minutes and 53 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Fixes the Obsidian table paste crash and the glued-prose stray row (#16).