Exclude MEO.Installer from the Synthesis patcher browser - #3
Merged
Conversation
The registry scraper's QueryForProjects does a RECURSIVE *.csproj scan and filters out only OutputType=Library. MEO.Installer is OutputType=Exe, so it would be published as a second browser entry alongside MEO.Synthesis. A missing SynthesisMeta.json does not exclude a project -- ConstructListings drops one only on Visibility=Exclude. Meta-file only. No algorithm, output, or build change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
installer/MEO.Installer/SynthesisMeta.jsonwith"Visibility": "Exclude". Meta file only — no algorithm, output, or build change. Mirrors marthofdoom/MAO#1.Why
Now that the dependency graph is enabled and MEO is on the Synthesis dependents page, the registry scraper will index this repo. Its project discovery (
Synthesis.Registry/Construction/QueryForProjects.cs) does a recursive*.csprojscan of the clone — it never readsMEO.sln— and filters out onlyOutputType=Library.MEO.InstallerisOutputType=Exe, so without this file it gets published as a second patcher entry next toMEO.Synthesis. A missingSynthesisMeta.jsondoes not exclude a project:ConstructListingsdrops one only onVisibility == Exclude, and a null customization is published with the nickname defaulted tomarthofdoom/MEO.Net effect without this: two near-identically named MEO entries in the patcher browser, the wrong one being the dev CLI — which references no
Mutagen.Bethesda.Synthesisand fails when run as a patcher.🤖 Generated with Claude Code