Skip to content

Include all postmeta data under post['postmeta']#3

Open
Cabalist wants to merge 16 commits into
marteinn:masterfrom
TechnoLoft:master
Open

Include all postmeta data under post['postmeta']#3
Cabalist wants to merge 16 commits into
marteinn:masterfrom
TechnoLoft:master

Conversation

@Cabalist
Copy link
Copy Markdown

Hey there,

Thanks for this project! I've been using this a lot to pull data out of wordpress exports. I noticed however that the majority of the post meta info was being thrown away. I added it in (and moved an import statement).

I've got some other fixes/improvements I'd like to PR if you are open to them. I really appreciate your work on this. :)

@marteinn
Copy link
Copy Markdown
Owner

marteinn commented Apr 5, 2022

Hi @Cabalist and thanks for the PR! Will review this and try to get back in a day or two. To be continued.

@Cabalist
Copy link
Copy Markdown
Author

Cabalist commented Apr 5, 2022

Awesome! Thanks! It evolved a little past the original PR with all the typing and some the python versions. We've been using it successfully in that time. 😄

@daar
Copy link
Copy Markdown

daar commented Apr 14, 2024

Hi, could you please merge this PR?

@todschmidt
Copy link
Copy Markdown

Nice PR. I just posted a super abbreviated version that mirrors one of your changes and felt obligied to point out that PRs should be as small as possible and not combine multiple features when possible.

That said @marteinn, worth taking a look. Or at mine :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants