Skip to content

Add Marko - #1

Open
tigt wants to merge 21 commits into
mainfrom
add-marko
Open

Add Marko#1
tigt wants to merge 21 commits into
mainfrom
add-marko

Conversation

@tigt

@tigt tigt commented Jan 17, 2023 •
edited
Loading

Copy link
Copy Markdown

LuLaValva
LuLaValva reviewed Jan 18, 2023
View reviewed changes

@LuLaValva LuLaValva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick comments, but overall these look nice

Comment thread content/2-templating/6-conditional/marko/TrafficLight.marko Outdated
Comment thread content/2-templating/6-conditional/marko/TrafficLight.marko Outdated
Comment thread content/4-component-composition/1-props/marko/UserProfile.marko Outdated
Comment thread content/4-component-composition/2-emit-to-parent/marko/AnswerButton.marko Outdated
Comment thread content/4-component-composition/2-emit-to-parent/marko/App.marko Outdated
Comment thread content/4-component-composition/4-slot-fallback/marko/FunnyButton.marko
Comment thread content/6-form-input/2-checkbox/marko/IsAvailable.marko Outdated
mlrawlings
mlrawlings reviewed Jan 18, 2023
View reviewed changes
Comment thread content/2-templating/6-conditional/marko/TrafficLight.marko Outdated
mlrawlings
mlrawlings reviewed Jan 18, 2023
View reviewed changes
Comment thread content/2-templating/6-conditional/marko/TrafficLight.marko Outdated
mlrawlings
mlrawlings reviewed Jan 18, 2023
View reviewed changes
Comment thread content/3-lifecycle/2-on-unmount/marko/Time.marko Outdated
mlrawlings
mlrawlings reviewed Jan 18, 2023
View reviewed changes
Comment thread content/4-component-composition/1-props/marko/UserProfile.marko Outdated
mlrawlings
mlrawlings reviewed Jan 18, 2023
View reviewed changes
Comment thread content/4-component-composition/2-emit-to-parent/marko/AnswerButton.marko Outdated
mlrawlings
mlrawlings reviewed Jan 18, 2023
View reviewed changes
Comment thread content/6-form-input/3-radio/marko/PickPill.marko Outdated
tigt and others added 6 commits January 18, 2023 12:02
@tigt @mlrawlings @LuLaValva
Apply suggestions from code review
a245195 
Everything except for the TS declarations since I think Dylan ought to weigh in

Co-authored-by: Michael Rawlings <mirawlings@ebay.com>
Co-authored-by: Luke LaValva <lukelavalva@gmail.com>
@tigt
Feedback: no space before method parens, no TS, else-if, ColorSelect …
8e17907 
…works now
@tigt
Pre-bugbash updates
ddfca26
@tigt
This is probably why they want us to provide a linter
c5f4c48
@nnelgxorz
Update Qwik logo (matschik#147)
bca04b9
@tigt
Finishing touches
1c75bee
@tigt tigt changed the title WIP: add Marko Add Marko Jan 30, 2023
@tigt
tigt marked this pull request as ready for review January 30, 2023 18:59
tigt and others added 11 commits January 30, 2023 14:16
@linux-foundation-easycla

linux-foundation-easycla Bot commented Apr 3, 2023 •
edited
Loading

Copy link
Copy Markdown

CLA Missing ID CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlrawlings mlrawlings mlrawlings left review comments
@LuLaValva LuLaValva LuLaValva left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@tigt @mlrawlings @LuLaValva @nnelgxorz @dangkhoipro @ismailassa @JohnsonMao @matschik @liou666 @mastastealth