MLE-31424: Backport to 11.3 changing xdmp:is-forwarded to xdmp:request-forwarded - #612
Merged
Merged
Conversation
vzhang-progress
commented
Jul 24, 2026
Contributor
- Change xdmp:is-forwarded to xdmp:request-forwarded as the builtin name changed in xdmp
- Tests: Unit tests all passed
vzhang-progress
requested review from
NeoSaber,
abika5,
Copilot and
josvanroosmalen
July 24, 2026 00:18
There was a problem hiding this comment.
Pull request overview
Updates mlcp’s reverse-proxy detection logic to use the renamed MarkLogic builtin xdmp:request-forwarded (replacing xdmp:is-forwarded) within the XQuery snippets embedded in ContentOutputFormat, aligning with MarkLogic 11.3’s builtin naming.
Changes:
- Switched the HTTP and XDBC forwarded-request detection queries from
xdmp:is-forwardedtoxdmp:request-forwarded. - Kept the existing header-based fallback behavior when the function lookup fails.
Comments suppressed due to low confidence (1)
src/main/java/com/marklogic/mapreduce/ContentOutputFormat.java:138
- Same as
HEADER_QUERY:XDBC_HEADER_QUERYno longer attemptsxdmp:is-forwarded()when present. Ifxdmp:request-forwardedis unavailable on the target server, this changes behavior compared to earlier releases. Consider looking up both names before falling back to request-header checks.
"let $f := fn:function-lookup(xs:QName('xdmp:request-forwarded'),0)\n" +
"return if (exists($f)) then $f() " +
"else (" +
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NeoSaber
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.