Skip to content

Fix SNMPv3 advance cached authoritative engineTime with the local clock #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n3-ruben-sanchez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SNMPv3 advance cached authoritative engineTime with the local clock #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const util = require ("util");
const crypto = require ("crypto");
const mibparser = require ("./lib/mib");
const Buffer = require('buffer').Buffer;
const { performance } = require ('perf_hooks');

var DEBUG = false;
var STRICT_INT_RANGE_CHECKS = false;
Expand Down Expand Up @@ -2439,6 +2440,7 @@ Session.prototype.onMsg = function (buffer) {
msgAuthoritativeEngineBoots: message.msgSecurityParameters.msgAuthoritativeEngineBoots,
msgAuthoritativeEngineTime: message.msgSecurityParameters.msgAuthoritativeEngineTime
};
this.setEngineTime (message);
if ( this.proxy ) {
this.msgSecurityParameters.msgUserName = this.proxy.user.name;
this.msgSecurityParameters.msgAuthenticationParameters = "";
Expand All @@ -2459,6 +2461,7 @@ Session.prototype.onMsg = function (buffer) {
} else if ( this.proxy ) {
this.onProxyResponse (req, message);
} else if (message.pdu.type == PduType.GetResponse) {
this.setEngineTime (message);
req.onResponse (req, message);
} else {
req.responseCb (new ResponseInvalidError ("Unknown PDU type '"
Expand Down Expand Up @@ -2974,7 +2977,43 @@ Session.prototype.walk = function () {
return this;
};

Session.prototype.setEngineTime = function (message) {
var params = message.msgSecurityParameters;
if (!params)
return;
if (!this.user || this.user.level < SecurityLevel.authNoPriv)
return;
var boots = params.msgAuthoritativeEngineBoots;
if (this.engineTimeBoots != null && boots < this.engineTimeBoots)
return;
var time = params.msgAuthoritativeEngineTime;
var now = performance.now ();
var elapsedSeconds = Math.floor ((now - this.engineTimeReceivedAt) / 1000);
var estimate = this.engineTimeBase + elapsedSeconds;
if (this.engineTimeBoots != null && boots == this.engineTimeBoots && time <= estimate)
return;
this.engineTimeBase = time;
this.engineTimeBoots = boots;
this.engineTimeReceivedAt = now;
};

Session.prototype.advanceEngineTime = function () {
if (!this.msgSecurityParameters || this.engineTimeReceivedAt == null)
return;
var elapsedSeconds = Math.floor ((performance.now () - this.engineTimeReceivedAt) / 1000);
var totalSeconds = this.engineTimeBase + elapsedSeconds;
var boots = this.engineTimeBoots;
if (totalSeconds > MAX_SIGNED_INT32) {
var rollovers = Math.floor (totalSeconds / (MAX_SIGNED_INT32 + 1));
totalSeconds = totalSeconds % (MAX_SIGNED_INT32 + 1);
boots = Math.min (boots + rollovers, MAX_SIGNED_INT32);
}
this.msgSecurityParameters.msgAuthoritativeEngineTime = totalSeconds;
this.msgSecurityParameters.msgAuthoritativeEngineBoots = boots;
};

Session.prototype.sendV3Req = function (pdu, feedCb, responseCb, options, port, allowReport) {
this.advanceEngineTime ();
var message = Message.createRequestV3 (this.user, this.msgSecurityParameters, pdu);
var reqOptions = options || {};
var req = new Req (this, message, feedCb, responseCb, reqOptions);
Expand Down