fix(tests): address review feedback on enhanced ported static tests - #7
Merged
marioevz merged 1 commit intoJul 29, 2026
Conversation
spencer-tb
force-pushed
the
ported-static-enhance-review-fixes
branch
from
July 29, 2026 10:24
097141f to
ef8c7ff
Compare
spencer-tb
marked this pull request as ready for review
July 29, 2026 10:43
Merged
2 tasks
marioevz
approved these changes
Jul 29, 2026
marioevz
merged commit Jul 29, 2026
d27e5f2
into
marioevz:ported-static-enhance-skill
8 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review feedback for ethereum#3215.
Discrimination restored
test_non_zero_value.py: call success flag stored inside theCodeGasMeasurewindow, a failed call was gas-identical to success for CALLCODE/DELEGATECALLtest_raw_call_gas_ask.py: caller side slot restored (unused 63/64 gas credited back), fork derivedtest_make_money.py: originalgas=2**256-20ask restored, the clamp is the subjecttest_copy_offset.py: nonzero tx calldata so a wrong in-bounds offset is observableCoverage
test_add_non_const.py: drop stalepre_alloc_mutable(execute-mode skip), canary slot, floor to Frontiertest_delegatecall_emptycontract.py: pinempty: Account.NONEXISTENTCleanup
FORWARDED_GAS/GAS_SLOT), drop dead_SIZE_LABEL,assert available > 0budget guardSkill
Related Issues or PRs
ethereum#3215.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture