Skip to content

fix(tests): address review feedback on enhanced ported static tests - #7

Merged
marioevz merged 1 commit into
marioevz:ported-static-enhance-skillfrom
spencer-tb:ported-static-enhance-review-fixes
Jul 29, 2026
Merged

fix(tests): address review feedback on enhanced ported static tests#7
marioevz merged 1 commit into
marioevz:ported-static-enhance-skillfrom
spencer-tb:ported-static-enhance-review-fixes

Conversation

@spencer-tb

@spencer-tb spencer-tb commented Jul 29, 2026

Copy link
Copy Markdown

Description

Review feedback for ethereum#3215.

Discrimination restored

  • test_non_zero_value.py: call success flag stored inside the CodeGasMeasure window, a failed call was gas-identical to success for CALLCODE/DELEGATECALL
  • test_raw_call_gas_ask.py: caller side slot restored (unused 63/64 gas credited back), fork derived
  • test_make_money.py: original gas=2**256-20 ask restored, the clamp is the subject
  • test_copy_offset.py: nonzero tx calldata so a wrong in-bounds offset is observable

Coverage

  • test_add_non_const.py: drop stale pre_alloc_mutable (execute-mode skip), canary slot, floor to Frontier
  • test_delegatecall_emptycontract.py: pin empty: Account.NONEXISTENT

Cleanup

  • name magic operands (FORWARDED_GAS/GAS_SLOT), drop dead _SIZE_LABEL, assert available > 0 budget guard
  • placeholder/stale docstrings rewritten

Skill

  • add: budget-vs-subject gas operands, zero-source-data trap, count-the-old-post's-slots, success-flag trap, final sweep checklist

Related Issues or PRs

ethereum#3215.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@spencer-tb
spencer-tb force-pushed the ported-static-enhance-review-fixes branch from 097141f to ef8c7ff Compare July 29, 2026 10:24
@spencer-tb
spencer-tb marked this pull request as ready for review July 29, 2026 10:43
@marioevz
marioevz merged commit d27e5f2 into marioevz:ported-static-enhance-skill Jul 29, 2026
8 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants