Skip to content

fix(pkgbuild): declare url scheme handler in desktop entry - #12

Open
ddiegosr wants to merge 1 commit into
maria-rcks:mainfrom
ddiegosr:fix/desktop-mimetype-url-scheme
Open

fix(pkgbuild): declare url scheme handler in desktop entry#12
ddiegosr wants to merge 1 commit into
maria-rcks:mainfrom
ddiegosr:fix/desktop-mimetype-url-scheme

Conversation

@ddiegosr

@ddiegosr ddiegosr commented Aug 27, 2026

Copy link
Copy Markdown

Fixes #11

Summary

Restores the MimeType= line that the upstream AppImage desktop entry
declares but the packaged entry drops, so t3code:// deep links resolve to a
handler at install time.

With the field present, the existing update-desktop-database pacman hook correctly registers the scheme on install with no further changes needed.

Changes

  • Add MimeType=x-scheme-handler/t3code;x-scheme-handler/t3code-dev; to the desktop entry in PKGBUILD
  • Bump pkgrel 1 to 2

Verification

Before

$ gio mime x-scheme-handler/t3code-dev
No default applications for “x-scheme-handler/t3code-dev”

After

$ gio mime x-scheme-handler/t3code-dev
Default application for “x-scheme-handler/t3code-dev”: t3code.desktop
Registered applications:
	t3code.desktop
Recommended applications:
	t3code.desktop

Summary by CodeRabbit

  • New Features

    • Added support for opening t3code and t3code-dev links through the desktop application.
  • Chores

    • Updated package release metadata for the standard and nightly builds.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 64a770d9-f8ec-44f9-9a2b-543669394263

📥 Commits

Reviewing files that changed from the base of the PR and between 8301b35 and 2b33417.

📒 Files selected for processing (4)
  • .SRCINFO
  • PKGBUILD
  • packages/t3code-nightly-bin/.SRCINFO
  • packages/t3code-nightly-bin/PKGBUILD

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The stable and nightly Arch packages move to release revision 2. Their desktop entries register handlers for the t3code and t3code-dev URI schemes.

Changes

Package updates

Layer / File(s) Summary
Release metadata
.SRCINFO, PKGBUILD, packages/t3code-nightly-bin/.SRCINFO, packages/t3code-nightly-bin/PKGBUILD
The stable and nightly package release numbers increase from 1 to 2.
Desktop URI handlers
PKGBUILD, packages/t3code-nightly-bin/PKGBUILD
The generated desktop entries register the t3code and t3code-dev URI schemes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 2b334

This localized package metadata update registers the URL scheme handler and bumps the package release; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: maria-rcks

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: declaring the URL scheme handler in the desktop entry.
Linked Issues check ✅ Passed The stable and nightly PKGBUILDs add both required URL scheme handlers, x-scheme-handler/t3code and x-scheme-handler/t3code-dev. The .SRCINFO files and pkgrel updates support the package revision. Thi…
Out of Scope Changes check ✅ Passed The changes are limited to the desktop entry declarations, corresponding .SRCINFO metadata, and pkgrel updates. All changes support the linked issue and PR objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The stable and nightly PKGBUILDs add both required URL scheme handlers, x-scheme-handler/t3code and x-scheme-handler/t3code-dev. The .SRCINFO files and pkgrel updates support the package revision. This satisfies issue #11.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ddiegosr
ddiegosr force-pushed the fix/desktop-mimetype-url-scheme branch from 2b33417 to e6cdd9d Compare August 27, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

t3code:// deep links have no handler — MimeType= missing from packaged desktop entry

1 participant