fix(pkgbuild): declare url scheme handler in desktop entry - #12
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe stable and nightly Arch packages move to release revision 2. Their desktop entries register handlers for the ChangesPackage updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized package metadata update registers the URL scheme handler and bumps the package release; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The stable and nightly PKGBUILDs add both required URL scheme handlers, x-scheme-handler/t3code and x-scheme-handler/t3code-dev. The .SRCINFO files and pkgrel updates support the package revision. This satisfies issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2b33417 to
e6cdd9d
Compare
Fixes #11
Summary
Restores the
MimeType=line that the upstream AppImage desktop entrydeclares but the packaged entry drops, so
t3code://deep links resolve to ahandler at install time.
With the field present, the existing
update-desktop-databasepacman hook correctly registers the scheme on install with no further changes needed.Changes
MimeType=x-scheme-handler/t3code;x-scheme-handler/t3code-dev;to the desktop entry inPKGBUILDpkgrel1 to 2Verification
Before
After
Summary by CodeRabbit
New Features
t3codeandt3code-devlinks through the desktop application.Chores